Eventing: CronJob event source attempts to invoke zipking when not needed

[slinkydeveloper]

Describe the bug
CronJob event source attempts to invoke zipkin even when config-tracing ConfigMap is left empty

Expected behavior
CronJob event souce should not attempt to invoke zipkin

To Reproduce
Steps to reproduce:

• Create a knative service
• Create a cronjob source using a knative service as a sink, eg with kn: kn source cronjob create my-cron --schedule "* * * * */1" --data "ping" --sink svc:myservice
• Look at cronjob log:

2020/02/20 17:25:04 failed to send the request: Post http://zipkin.istio-system.svc.cluster.local:9411/api/v2/spans: dial tcp: lookup zipkin.istio-system.svc.cluster.local: no such host
2020/02/20 17:25:05 failed to send the request: Post http://zipkin.istio-system.svc.cluster.local:9411/api/v2/spans: dial tcp: lookup zipkin.istio-system.svc.cluster.local: no such host
2020/02/20 17:25:06 failed to send the request: Post http://zipkin.istio-system.svc.cluster.local:9411/api/v2/spans: dial tcp: lookup zipkin.istio-system.svc.cluster.local: no such host

/good-first-issue

[knative-prow-robot]

@slinkydeveloper:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Describe the bug
CronJob event source attempts to invoke zipkin even when config-tracing ConfigMap is left empty

Expected behavior
CronJob event souce should not attempt to invoke zipkin

To Reproduce
Steps to reproduce:

• Create a knative service
• Create a cronjob source using a knative service as a sink, eg with kn: kn source cronjob create my-cron --schedule "* * * * */1" --data "ping" --sink svc:myservice
• Look at cronjob log:

2020/02/20 17:25:04 failed to send the request: Post http://zipkin.istio-system.svc.cluster.local:9411/api/v2/spans: dial tcp: lookup zipkin.istio-system.svc.cluster.local: no such host
2020/02/20 17:25:05 failed to send the request: Post http://zipkin.istio-system.svc.cluster.local:9411/api/v2/spans: dial tcp: lookup zipkin.istio-system.svc.cluster.local: no such host
2020/02/20 17:25:06 failed to send the request: Post http://zipkin.istio-system.svc.cluster.local:9411/api/v2/spans: dial tcp: lookup zipkin.istio-system.svc.cluster.local: no such host

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sciamp-dev]

Hello, I'm a student looking forward to partecipate in this year GSoC with JBoss/Knative.
I'd like to work on this :)

[sciamp-dev]

/assign

[guimou]

FYI, it does not happen only with a CronJob event source. I have a KafkaSource event defined, with a Service sink. It works perfectly well, but after 25 minutes (at least I have exactly the same behavior with two sources of the same kind, not created at the same time) it begins throwing this error every second.

{"level":"info","ts":"2020-03-08T22:03:23.326Z","logger":"kafkasource","caller":"kafka/consumer_handler.go:65","msg":"Starting partition consumer, topic: odfi, partition: 0"}
{"level":"info","ts":"2020-03-08T22:03:23.327Z","logger":"kafkasource","caller":"kafka/consumer_handler.go:65","msg":"Starting partition consumer, topic: odfi, partition: 1"}
2020/03/08 22:28:08 failed to send the request: Post http://zipkin.istio-system.svc.cluster.local:9411/api/v2/spans: dial tcp: lookup zipkin.istio-system.svc.cluster.local on 172.30.0.10:53: no such host
2020/03/08 22:28:09 failed to send the request: Post http://zipkin.istio-system.svc.cluster.local:9411/api/v2/spans: dial tcp: lookup zipkin.istio-system.svc.cluster.local on 172.30.0.10:53: no such host

Ref:

apiVersion: sources.knative.dev/v1alpha1
kind: KafkaSource
metadata:
  name: odfi-split
  namespace: ach
spec:
  consumerGroup: odfi-split
  bootstrapServers: my-cluster-kafka-bootstrap.kafka:9092
  topics: merchant-upload
  sink:
    apiVersion: serving.knative.dev/v1alpha1
    kind: Service
    name: odfi-split

[siddharth952]

@sciamp-dev Are you still working on this?

[sciamp-dev]

@siddharth952 ideally, yes. But at the moment I have some delay due to coronavirus. If you want to take over, feel free to do so. I'll not have time before next week.

[slinkydeveloper]

As soon as #3026 is merged, this should be fixed easily injecting the config map in the envs of the cron job receive adapter, like done here for ApiServerSource:

• https://github.com/knative/eventing/pull/3026/files#diff-d99b024fa0cd240e5a9ba150e807531a
• https://github.com/knative/eventing/pull/3026/files#diff-edbbfc473b7a21fb3031e92071dcca86
• https://github.com/knative/eventing/pull/3026/files#diff-d86a389c49e177be3527a5acd33138ae

[lionelvillard]

Is this issue still relevant? The single tenant ping adapter is not used anymore.

Can you try with 0.14?

[slinkydeveloper]

Maybe it's not relevant anymore because the ping source is deprecated, but the same problem applies to other sources i think, please look this discussion https://knative.slack.com/archives/CQBKVH4QY/p1587470867045600

[slinkydeveloper]

/close