Enterprise: Toolbar: A toolbar with a searchfield in a list details div text is same color as searchfield

Created on 1 May 2019  路  9Comments  路  Source: infor-design/enterprise

Describe the bug
The text color matches the searchfield's color, so you can't read it. This is happening for a searchfield in a toolbar in a list details area. Also, the clear button is over the magnifiying glass button when there is a value in the searchfield, but it's collapsed.

To Reproduce
Steps to reproduce the behavior:

  1. Copy list-detail.zip into your codebase, and navigate to it.
  2. (TJM) On branch http://localhost:4000/patterns/list-detail.html i put it
  3. Click into the toolbar search field (the magnifying glass icon) and start typing
  4. See error

Expected behavior
Need to be able to see what is being typed.

Version
v4.19.0-dev

Screenshots
SearchFieldTextIssue

Platform

  • All
[2] critical

All 9 comments

Additionally.

  • the placeholder text is the same color as the text
  • when search is collapsed and you hover an x appears when it shouldnt

Wondering if this worked before or is a new combination? Just wondering if we broke something

I feel like it was working in the landmark case before. I'm just not sure when. It looks like a rule in _list-detail.scss is what is setting the current color to transparent.

This is happening in our mainline, so it's probably been there since v4.17 . I've put in a temp fix in the landmark code
// Temporary fix until https://github.com/infor-design/enterprise/issues/2075 is fixed and available .list-detail .toolbar .searchfield-wrapper input { color: inherit; }

for now.

Very very interesting. So something was probably done to "unmask" this and it's very odd that at one point we set the color: transparent. Honestly I think we can remove that whole selector in our codebase, but we'll investigate.

Was able to remove this whole snippet, and it seems like that was the culprit

The text color is now different as the search field however, The text color is the same with placeholder & when search is collapsed and you hover an x appears when it shouldn't.
Verified in: http://4180-rc2-enterprise.demo.design.infor.com/patterns/list-detail.html

Hi @tmcconechy, Already tested in all OS browsers and noticed that the placeholder is not showing in Windows10 IE11 browser.
Will move to QA failed. Thank you.

Tested in: http://4180-rc3-enterprise.demo.design.infor.com/patterns/list-detail.html

Screen Shot 2019-05-03 at 1 45 51 PM

@EdwardCoyle since we have this working in most browsers, let's split @janahintal 's latest finding as a separate issue (for 4.19 sprint) so we can release 4.18.0.

Raised #2093 for that one

Was this page helpful?
0 / 5 - 0 ratings