Eddiebot: Bio commands/flags should be all lower case

Created on 7 Jul 2020  ·  5Comments  ·  Source: EddieJaoudeCommunity/EddieBot

In this command the flags should be converted to lower case, so whatever case the user types will still work

good first issue

Most helpful comment

okay thanks, @alrifay let me fix it

All 5 comments

This has been sorted out right @eddiejaoude

@Ruth-ikegah I don't think it is.

args[0] should be converted to lower case on src/commandHandlers/bio.ts line 17

https://github.com/EddieJaoudeCommunity/EddieBot/blob/79965375af98d476c1d191348319b6e27ac8d70b/src/commandHandlers/bio.ts#L17

okay thanks, @alrifay let me fix it

Thanks @Ruth-ikegah . I think I only half did it 🤦‍♂️ . @alrifay is right, it is needed there too. I only changed it further down here

https://github.com/EddieJaoudeCommunity/EddieBot/blob/develop/src/commandHandlers/bio.ts#L54

What I did, is actually not good looking at it now. Maybe it would be better to save args[0] to a const at the top of the function, then it is only done in one place.

Maybe it would be better to save args[0] to a const at the top of the function, then it is only done in one place.

Oh I think you did that already here https://github.com/EddieJaoudeCommunity/EddieBot/pull/163

Was this page helpful?
0 / 5 - 0 ratings