Easy-digital-downloads: Problems with the custom taxonomies of EDD

Created on 27 Jan 2017  路  4Comments  路  Source: easydigitaldownloads/easy-digital-downloads

Related: github.com/Yoast/wordpress-seo/issues/ #5266 #6539 and #6538.

From yoast plugin:
_Worth nothing on part of the issue here is that EDD should not set a width on the primary column. The standard in WP is to set a width on all columns except the primary one._

component-administration priority-medium

Most helpful comment

We do need to find a better way to handle this. It's a super tight space but right now our columns are defined to take all of it. That's not a flexible approach.

All 4 comments

We do need to find a better way to handle this. It's a super tight space but right now our columns are defined to take all of it. That's not a flexible approach.

Why the width is set for each column in the first place?

If we see columns for posts or products (WC) it displays just fine, except it eats up the character n from the word Description

woocommerce

It's only because of the extra Image column.

Some EDD addons have added custom columns to the download_tag and download_category taxonomies, like EDD Points and Rewards.

points_rewards

I'm proposing that we just stop the defined widths here. They don't add much benefit, but they hurt a _lot_ when other plugins modify the table... which they should be able to do in peace.

Yoast has already made great adjustments that help with the aforementioned "conflict." But really, we just need to get out of the way and let the table flow. WordPress itself defines a couple of column widths, but that's fine.

Our Points & Rewards extension defines some widths, so we can get that removed as well. There's nothing wrong with the final result:

screenshot 2017-08-04 10 10 36

Sure, the Description column can end up skinny and tall if the term has a description. But if you don't want to see it, you can just go up to the Screen Options and disable the display.

So yea... let's get out of the way.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

michaelbeil picture michaelbeil  路  5Comments

SDavisMedia picture SDavisMedia  路  3Comments

DevinWalker picture DevinWalker  路  6Comments

Ismail-elkorchi picture Ismail-elkorchi  路  3Comments

davidsherlock picture davidsherlock  路  4Comments