Easy-digital-downloads: Actually use the new iPhone icon

Created on 4 Nov 2016  路  5Comments  路  Source: easydigitaldownloads/easy-digital-downloads

We have the wrong image source in payments-history.php on line 63: assets/images/icons/iphone.png

Should be templates/images/icons/iphone.png.

type-bug
Source
picture michaelbeil

Most helpful comment

Before:
screen shot 2016-11-04 at 6 23 44 pm
After:
screen shot 2016-11-04 at 6 23 50 pm

picture michaelbeil on 4 Nov 2016
❤1 🎉1

All 5 comments

Before:
screen shot 2016-11-04 at 6 23 44 pm
After:
screen shot 2016-11-04 at 6 23 50 pm

michaelbeil picture michaelbeil on 4 Nov 2016
❤1 🎉1

@michaelbeil @cklosowski Can we get the alt="" attribute added while we're in there?

SDavisMedia picture SDavisMedia on 4 Nov 2016

Also, why was the assets/images/icons/ location wrong? It's our asset and that one should have been replaced with the new icon. https://github.com/easydigitaldownloads/easy-digital-downloads/tree/master/assets/images/icons

Just curious if I missed some other detail.

SDavisMedia picture SDavisMedia on 4 Nov 2016

@SDavisMedia what do you want on the Alt Tag? What we should do is move that .png file over to the assets dir. It doesn't belong in the template images.

cklosowski picture cklosowski on 4 Nov 2016

Looks perfect to me! Thanks.

SDavisMedia picture SDavisMedia on 4 Nov 2016
Was this page helpful?
0 / 5 - 0 ratings

Related issues

davidsherlock picture davidsherlock  路  4Comments
zackkatz picture zackkatz  路  4Comments
DrewAPicture picture DrewAPicture  路  5Comments
amdrew picture amdrew  路  5Comments
scottbuscemi picture scottbuscemi  路  5Comments