E107: & vs & in e_url addon and validation

[Jimmi08]

Bug Description

e_url uses & in URL configuration and it causes validation error with HTML validator extension

How to Reproduce

Steps to reproduce the behavior:

1. I noticed this with the forum plugin or use newforumposts menu

Expected Behavior

No warning error, but W3C validation didn't find this, so maybe enough is just to explain why did you decide to use & in httpBuildQuery method instead of &. Thanks

Screenshots

[Jimmi08]

@Moc it should be labeled as a question, it wasn't intention marked it as bug

[Deltik]

An HTML validation error caused by e107 sounds like a bug to me. I'll add an issue template for the question label.

Update: Issue template for questions is live!

[Jimmi08]

@Deltik Great. Thank you.
It's easier this way. I still dislike to mark something like bug, or enhancement, it should be on core developers to mark this way. I just noticed this type of labeling in other repository (that word type):

[Deltik]

@Jimmi08: Thanks for the feedback! I've prepended all the issue type labels with "type:".

As for the auto-type assignment, the types are fundamentally different, so it makes sense to add them right off the bat. If that's a mistake for whatever reason, a maintainer can change it later.

Issue statuses are now prepended with "status:", so that should make statuses clearer, too.

[Jimmi08]

@Jimmi08 Perfect! Thank you.

[Deltik]

@Jimmi08: #4067 should fix this issue. Can you try to apply the following patch (same changes as #4067) to see if the issue is fixed?: fix-4054.patch

[Jimmi08]

@Deltik Thanks. I will do it ASAP.

Could this be related?: https://github.com/e107inc/e107/issues/3943
the point is that if there is & then that test fails because of ';'in the query.
I have no idea why it just doesn't work in some cases.

[Jimmi08]

What I did (I never used patch file before):
I am using this addon for testing:
http://users.skynet.be/mgueury/mozilla/

• sync with Github via admin
• on local repository applied your patch txt file, only e107_class.php was changed
• manual upload this file to the server
• cleared all caches (this was important)

Result:

• homepage (newsforum menu is there) - all similar errors fixed
• forum plugin - checked all pages (viewforum, viewtopic etc) - all similar errors fixed,
• checked download, news, gallery.