Dynamo: bug --> Get Family Parameter

[erfajo]

[QilongTang]

@erfajo Thank you for reporting, this is a regression we found after 2.X from Dynamo 1.3.4, it has been officially fixed in the coming release Dynamo 2.1.0, you can check a series of PR starting from https://github.com/DynamoDS/Dynamo/pull/9367. If you still has questions or concerns, feel free to comment and reopen.

[QilongTang]

@erfajo I would echo what I wrote in the PR, the new Json attribute we added in the node will try to "remember" what user selects when saving thus restore the selected Item when opening the file. I believe this is exactly the cause of the bug you reported. We have finished fixing and testing on our end and in DynamoForRevit, that is the reason I closed this issue with my response in the first place.

Here is an example for you to review as the new behavior:

"Nodes": [
    {
      "ConcreteType": "DSRevitNodesUI.Categories, DSRevitNodesUI",
      "SelectedIndex": 6,
      "SelectedString": "OST_DuctTerminal",
      "NodeType": "ExtensionNode",
      "Id": "e16b9ac4ad604e7eb4d29a7975335d7c",
      "Inputs": [],
      "Outputs": [
        {
          "Id": "ac2e1b04ef994a4fb5dbe4b2855d1097",
          "Name": "Category",
          "Description": "The selected Category.",
          "UsingDefaultValue": false,
          "Level": 2,
          "UseLevels": false,
          "KeepListStructure": false
        }
      ],
      "Replication": "Disabled",
      "Description": "All built-in categories."
    }
  ]

I don't think the goal here is to restore to the same index serializing/ deserilizing behavior back to v1.3.4 when index and string was mixed into. Since Json serialization/deserialization is based on class properties, the current way support the same behavior with slightly different information saved. Also since 2.1.0 is already internally released and consumed by Revit group, any changes to file format will be extremely hard for us.

Let me know if you have more comments.

Cheers,
Aaron-

[QilongTang]

@erfajo Again, I would echo this is a drop down issue which has been fixed by me in v2.1.0. Please see the attached gif, I believe I did what you have described in the issue description and the bug can no longer be reproduced.

Cheers,
Aaron-