Dotnet-api-docs: The documented Default Http Request version is incorrect.

Created on 9 Oct 2019  路  3Comments  路  Source: dotnet/dotnet-api-docs

Currently the doc is listing the default HTTP version for .NET Core 2.1+ to be v2.0, when in fact it's 1.1.

This page says .NET Core 2.1+ uses HTTP/2 by default:
https://docs.microsoft.com/en-us/dotnet/api/system.net.http.httprequestmessage.version?view=netcore-3.0#property-value
https://github.com/dotnet/dotnet-api-docs/blob/master/xml/System.Net.Http/HttpRequestMessage.xml#L464

But here's where the version is being set:
https://github.com/dotnet/corefx/blob/release/3.0/src/System.Net.Http/src/System/Net/Http/HttpRequestMessage.cs#L195

That version comes from this constant which says 1.1 (except for UWP):
https://github.com/dotnet/corefx/blob/release/3.0/src/System.Net.Http/src/System/Net/Http/HttpUtilities.cs#L17

/cc @karelz

doc-bug

All 3 comments

Thanks @dotMorten. This was a breaking change introduced in 3.0 and the fix was done in PR #3285.

If you see the line you're referencing on this repo, you'll see that it says it's 2.0 only for .NET Core 2.1 or 2.2.

That fix should be live in a few hours.

@mairaw Nice! You beat me to it!

Super fast! 馃槷
Thanks @mairaw!

And thanks @dotMorten for reporting it ...

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jfranki picture jfranki  路  5Comments

mairaw picture mairaw  路  6Comments

FierceLlama picture FierceLlama  路  3Comments

martinmeeser picture martinmeeser  路  3Comments

kapsiR picture kapsiR  路  8Comments