Dotnet-api-docs: Add note, that Calendar.GetWeekOfYear differs from ISO 8601 week of year

Created on 9 Jan 2020  路  8Comments  路  Source: dotnet/dotnet-api-docs

Affected docs: /xml/System.Globalization/Calendar.xml

Hints:

area-System.Globalization broken-link doc-bug

All 8 comments

I found out, that this is already in /xml/System.Globalization/CalendarWeekRule.xml...
But the referenced blog entry link is broken: https://go.microsoft.com/fwlink/?LinkId=160851

@kapsiR @mairaw Is this already resolved or can I work on this issue? Do we need to correct the link in CalendarWeekRule.xml What about Calendar.xml?

The broken link in /xml/System.Globalization/CalendarWeekRule.xml has been fixed.

Nevertheless I would prefer that the remarks of Calendar.GetWeekOfYear in /xml/System.Globalization/Calendar.xml would be updated accordingly too.

@mairaw Would be cool if @rohansp can update the Remarks section of Calendar.GetWeekOfYear to have this information there too?

@tarekgh can you please help triage?

The comment needed to be added looks reasonable to me. @kapsiR do you want open a PR for it?

@tarekgh Yes I can submit a PR for this, but if @rohansp wants to try it he can do it too

@kapsiR go ahead.

Thank you for offering your help, @kapsiR. Let us know if you need any help with creating PRs in dotnet-api-docs.
You don't need to build anything locally to verify your changes, you can let the CI in the PR give you the results.
Please add me and Tarek as reviewers.

Was this page helpful?
0 / 5 - 0 ratings