Devilution: loadsave.cpp

[AJenbo]

• [x] 426564 (LoadGame)
• [x] 426AE2 (BLoad)
• [x] 426AF0 (ILoad)
• [x] 426B2C (ILoad_2)
• [x] 426B68 (OLoad)
• [x] 426B7F (LoadPlayer)
• [x] 426BA9 (LoadMonster)
• [x] 426BDE (LoadMissile)
• [x] 426C08 (LoadObject)
• [x] 426C2A (LoadItem)
• [x] 426C5F (LoadPremium)
• [x] 426C89 (LoadQuest)
• [x] 426CDE (LoadLighting)
• [x] 426D00 (LoadVision)
• [x] 426D22 (LoadPortal)
• [x] 426D45 (SaveGame) #376
• [x] 427203 (BSave)
• [x] 427211 (ISave)
• [x] 427258 (ISave_2)
• [x] 42729F (OSave)
• [x] 4272B7 (SavePlayer)
• [x] 4272E1 (SaveMonster)
• [x] 42730B (SaveMissile)
• [x] 427335 (SaveObject)
• [x] 427357 (SaveItem)
• [x] 427381 (SavePremium)
• [x] 4273AB (SaveQuest)
• [x] 427404 (SaveLighting)
• [x] 427426 (SaveVision)
• [x] 427448 (SavePortal)
• [x] 42746B (SaveLevel) #376
• [x] 42772F (LoadLevel) #376

[ghost]

There are a few mistakes I made with this one when Devilution was first created, in order to get it to compile. Will clean it up soon.

[ChaosMarc]

I think this issue deserves the "Minimal Differences" label as well, as the the missing functions SaveGame, SaveLevel and LoadLevel are mentioned here as such: #376

should a new issue be created for them?

PS: and I think we should remove #257, #258, #259, #260, #261 and #283 from the milestone, as we only should list "file"-issues and not issues for single/multiple functions. It would make the milestone appear a bit more clearly

[AJenbo]

Sounds good, I originally wanted to poke a bit at the remaining functions before assigning the label, but the label applies in any case.

That means we are 33% done with the mile stone (if we see min-diff as completed)

[ChaosMarc]

and almost 50% finished if we look at functions and not files:

@AJenbo would you mind also removing #258 and #283 from the milestone's completed issue list?

[AJenbo]

Cool :) On a per line level we are at almost 75%

Fixed, though that did drop us down to 30% files done.

[mewmew]

Indeed, very close to 50%!

u@x1 ~> devilution-progress
progress: 48.02% (911/1897)

[AJenbo]

Exactly 1% of functions are min-diff :D

[ghost]

Fixed with latest commit #865 ;)