Devilution: Create classes, constructors, and static variables

[ghost]

This issue will be for creating the relevant C++ parts of the code. The decompiler doesn't have enough information on it's own to do so. The majority of data is currently written to the .DATA section of the executable, instead of .RDATA like the original. Classes will help to declare static/external variables and functions. The PSX symbol defines this for most functions/data.

Constructors should be used for a few files, example engine.cpp:

Class Engine
{
  public:
    gdwRandSeed;
    CelDecodeRaw(blah blah blah);
  private:
    Engine();
    ~Engine();
}
Engine()
//initialize CCritSection
~Engine()
//delete CCritSection

[squidcc]

It's possible to have static initializer functions without using C++, for example:

static void msgcmd_cpp_init_2(void)  // static initializer function
{
  msgcmd_init_event();
  msgcmd_cleanup_chatcmd_atexit();
}
// switch data segment to CRT$XCU (static constructor list)
#pragma data_seg(".CRT$XCU")
// store a pointer to the init function
void (*msgcmd_init)(void) = msgcmd_cpp_init_2;
// restore normal data segment
#pragma data_seg()

No idea if this works with mingw but I assume it would have to in order to be compatible with static libs.

[sskras]

Was that fixed already? The commit stream is so fast this week that it drowned me down a bit.

[mewmew]

Was that fixed already? The commit stream is so fast this week that it drowned me down a bit.

Haha, you are not the only one to be lost in the flurry of commits. Every time I go for lunch, sleep for a few hours, or look away from the screen, @galaxyhaxz, @AJenbo, @JustAnotherGuid and @qndel bump bin exactness by another percent or 5.

[AJenbo]

this was done as part of the move from C++ to C afaik

[ghost]

There really aren't any C++ parts of the code except msgcmd.cpp (which is sitting in a PR) and possibly the Critical section constructors. I thought originally Diablo had used far more CPP then it actually did, hehe.