Devilution: Crash related to Golem in Multiplayer + some hints

[Ogodei]

Hello :)

I have downloaded the nightly branch of Devilution and compiled the .exe without touching anything. After that, I've created a multiplayer game with the character I'm using to play vanilla D1, but I cannot enter any dungeon level because it crashes during the loading phase, showing this message:

" Illegal enemy monster 251 for monster "Golem" "

I wasn't able to find the cause of it, due to my limited coding knowledge. However, I would like to share 2 tips for the devs! In the monster table, the very two first columns are commented "mType" and Flag. They should, be commented, instead, as Width\Height (basically, sprite size) and Seeding Size :)

Thanks a lot for your time in developing this source code and for reading this!

[AJenbo]

@Ogodei I'm unable to replicate this using the latest nightly (create new singe player game with the warrior, go to church), if you are still getting the issue then please attache a save game that can be used to replicate it.

On the bright side I have now corrected "flag" to be "width" :)

update: turns out this is MP only, and I'm able to replicate it now :D

[AJenbo]

The issue was introduced in this commit: 1430acc47f517948cfbface545fb38a05ea5d7d0 specifically it's one of the chnages in struct.h

[Ogodei]

I can confirm the issue is now fixed. Thanks a lot guys!

[mewmew]

I can confirm the issue is now fixed. Thanks a lot guys!

That's great! Good job @Ogodei and @AJenbo for reporting the issue, figuring out how to make it reproducible and fixing it :) Closing the issue as it's now been fixed.

[AJenbo]

@mewmew don't forget that the PR still has to be merged ;)

[mewmew]

@mewmew don't forget that the PR still has to be merged ;)

Fair point :) I was just trigger happy and in a good mode on the train ride home. Re-opened, till the PR gets merged.