Desktop: Bar at the top when part of multiple servers stays white whatever you try

Created on 6 Aug 2018 · 15Comments · Source: mattermost/desktop

I confirm (by marking "x" in the [ ] below: [x]):

[x] This is not a troubleshooting question. Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/.
[x] This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[x] I have read contributing guidelines.

Ticket: https://mattermost.atlassian.net/browse/MM-16546

Summary

When being part of multiple servers, there is a selection bar at the top. This bar is white whatever I’ve tried, while my desktop theme is dark and so are my Mattermost ones.

Environment

Operating System: Arch Linux
Mattermost Desktop App version: 4.1.2
Mattermost Server version: 5.1.0 for both servers

Steps to reproduce

Join two different servers.

Expected behavior

The selection bar picks desktop theme.

Observed behavior

Selection bar remains white.
screenshot

Possible fixes

Use desktop theme colors? If not possible, allow to choose at least.

Help Wanted Up For Grabs

Source

ArchangeGabriel

All 15 comments

@yuya-oc @asaadmahmood thoughts on this? I would prefer not to have a separate setting for this if we can have something compatible with the Mattermost theme or windows theme?

esethna on 7 Aug 2018

@yuya-oc Can't we detect if a person has set the windows theme dark or Mattermost theme? If we can just pick any of those colors, or even a boolean for a dark variable, we can customise our app accordingly.

Different apps change their behaviour based on the windows theme, so I'm guessing there might be a way for us to atleast detect the Windows theme option.

asaadmahmood on 8 Aug 2018

@ArchangeGabriel
b2d6d0dd480ba174fbc2a4cbc4e6fe95
Can reproduce as well and this is even more annoying on Qt based interfaces. I'm a KDE guy myself.

As you can see the situation for KDE/LXQt, etc. based users is quite even more annoying in the sense of even our theme is not respected. There is nothing Mattermost could do in this context and this needs to be hacked in the libchromiumcontent viewer directly in the chromium repos. :-/
screenshot_20180809_173709
But for your problem more specifically with the bar, there are high chances to get it fixed here.

wget on 9 Aug 2018

Nope, I’m on KDE Plasma. ;) I think your GTK theme does not change the color of the top bar. Most don’t, as I realized y-day when updating Thunderbird (the Inbox view stays black on white on most dark themes that I know of).

ArchangeGabriel on 9 Aug 2018

@ArchangeGabriel Yes you might be right. I'm using Plasma Breeze for GTK. Which theme are you using for Plasma and for GTK?

wget on 9 Aug 2018

It depends what we’re talking about. I’m using Materia-dark-compact for GTK, but regarding Qt it’s a bit more complicated. I’m using Kvantum’s MateriaDark as Qt style, Materia-Dark for window decorations and Arc-Color for Plasma theme. Not sure which one is responsible for the dark menu bar, but I would say the GTK theme.

ArchangeGabriel on 9 Aug 2018

For having dug a bit in the electronjs/chromium code base for another Mattermost dekstop bug I still need to fix, I can confirm the menu bar is rendered via GTK. The Aria UI interface of Chromium is managed by an old version of GTK 3.x with a bunch of legacy things.

wget on 9 Aug 2018

@ArchangeGabriel @wget Please let me confirm. Which is "the top bar" you called? As far as reading the first summary, I understood there is the issue on "tab bar".

where_is_issue

However, in discussion, I felt you are talking about "menu bar" because you are talking about desktop environment such as KDE and GTK. Which is correct? If it is "tab bar", we might be able to control its color in application code via css.

@asaadmahmood @esethna We can't detect desktop theme color on Linux due to electron API. We can do:

Windows: Get accent color and system color
Mac: Detect whether it's dark mode
Pick up webapp theme color (Can we get it via Mattermost API?)

yuya-oc on 10 Aug 2018

@yuya-oc Yes, issue is on the “tab bar”. @wget is the one having issue with the menu bar, I don’t (as you can see on my screenshot it is properly dark).

ArchangeGabriel on 10 Aug 2018

👍1

@yuya-oc if we can get the webapp theme color, then that would be great. Not sure if the theme color is forwarded in the API, maybe @hmhealey would know.

asaadmahmood on 10 Aug 2018

For the record, I got the menu bar fixed from my side. Just had to check an additional checkbox in my settings.
screenshot_20180814_112844

So this confirms the menu bar problem was on my side.

There is still the tab bar issue left that still needs to be fixed then :)

wget on 14 Aug 2018

👍1

@wget Cool, thanks for the update on that.

asaadmahmood on 14 Aug 2018

@asaadmahmood It would be difficult to give the desktop app access to the web app theme, and it may also look weird when switching between servers with different themes. I'd lean towards trying to get theme information from the OS although that'll also be tricky since it'll be mostly OS-specific code to do that

hmhealey on 16 Aug 2018

@hmhealey That’s a good point, I was hesitant to mention it and decided I wouldn’t bother your people about that and just use the same theme in each tab. But yes indeed, being the same colors as the menu bar makes probably much more sense.

ArchangeGabriel on 16 Aug 2018

Ticket for reference: https://mattermost.atlassian.net/browse/MM-16546.