Desktop: share dialog in new client badly designed

[jospoortvliet]

Hi,

Just looking at the new client, 2.4.x or so, and its new share dialog:

This really needs input from @nextcloud/designers ... Perhaps we can sit at FOSDEM and mockup something that looks designed for normal users, not system administrators?

[tobiasKaminsky]

Indeed, this is really awful :/

[jancborchardt]

Folks, when and why was this changed? :\ Where’s the spec discussion where designers were involved?

Once we introduce a change like this, it is an absolute mess to clean up and roll back. Splitting this into two tabs is exactly the same mistake we did with splitting the Activity view in settings into 3 separate lists. It’s confusing and a mess of an interface – even the amount of options on the link alone.

We can’t have parts of our project just do their own thing design-wise. We are all working on one project and it has too look and work in a coherent fashion.
Please follow the server design on aspects where that exists (like Sharing and Activity), and if there are additions to be made, please always involve @nextcloud/designers in the planning process already.

[MorrisJobke]

Folks, when and why was this changed? :\ Where’s the spec discussion where designers were involved?

It was downstreamed ;)

[jancborchardt]

It was downstreamed ;)

Ugh, ok. Then sorry for the assumption! :)

Then for clarification @nextcloud/client are we still trying to change as little as possible to make downstreams possible? Cause that share dialog (and the mentioned Activity list in 3 separate tabs) are really some things we could and should improve the design of on our end. :)

[rullzer]

@jancborchardt well I haven't look at the code that is moved around. But it is more a question of time (and all the trouble it gives with more downstreamed changes). But in general yes we should be able to fix this. The question is when.

[camilasan]

@jancborchardt "Perhaps we can sit at FOSDEM and mockup something that looks designed for normal users, not system administrators?" +1

[jancborchardt]

@camilasan great idea! :) Let's do that. (Haha, only now saw that @jospoortvliet wrote that below the screenshots. ;)

[jancborchardt]

Here's the mockup for sharing, to combine users and links :)

https://cloud.nextcloud.com/s/rg3M3m7SYrW6gXg

[camilasan]

From talking to @jancborchardt: the "New share link" will be displayed once the user click in the input "Share".

[tobiasKaminsky]

For android and iOS @jancborchardt came up with https://github.com/nextcloud/android/issues/2485, which should be roughly the same as web UI.

[jospoortvliet]

Please remember to make sure that file-drop works! In the screenshots above and in the current client, this is not available. It shows the third description under 'download/view' and 'download/view/upload' as "receive files from others without revealing the contents of the folder" but you can't actually choose it.

I suppose the dialog should look as close as possible to the web UI and at least have all the functions:

• copy direct link
• share to user/group/federated/email
• share link
  access options:
  ( ) read only
  ( ) allow upload and editing
  ( ) file drop (upload only)
  [ ] Password protect
  [ ] Set expiration date

Just like:

Some day, tags, comments and activities should be integrated, I suppose...

[jancborchardt]

Yes, those options are in what in the mockup above is called "Menu building block", that is the 3-dot popover menu.

And as @pixelipo said in https://github.com/nextcloud/server/issues/6620#issuecomment-337874318

What about simply having 3 independent (checkbox) items:

• View (read)
• Upload
• Edit

Because we have a lot of people asking for the ability to share a folder with viewing and upload permissions, but not edit (meaning delete). For example if you share a vacation pictures folder with others where you want them to add stuff but not accidentally delete.

[jospoortvliet]

The new share dialog is merged, so let's close this.