Darktable: in select module : un-altered select does nothing

[TurboGit]

Describe the bug
un-altered select does nothing

To Reproduce

1. Go to lighttable, open select module
2. Select one picture and discard history
3. On select module, click on select all
4. Then click on select untouched
5. See error, no picture are selected

Expected behavior
Un-alterred pictures should be selected

Platform (please complete the following information):

• Darktable Version: master
• OS:GNU/Debian

Additional context

[TurboGit]

@phweyland : I suspect an issue with the new hash computation maybe ?

[johnny-bit]

Needs investigation here: https://github.com/darktable-org/darktable/blob/48850e8e6feb15729451a8fba7f64cf4a24e9f60/src/common/selection.c#L354-L386

probably needs better query handling.

[jenshannoschwalm]

Can't check the suspicious code but don't we need mutex protection of the database here?

[johnny-bit]

If it's needed here it's needed in loads of places ;) I'd propose also a transaction :)

[TurboGit]

Ok, now I'm not even sure this has been working at some point. The unaltered means in current code no history at all:

    else if(collection->params.filter_flags & COLLECTION_FILTER_UNALTERED)
      wq = dt_util_dstrcat(wq, " %s id NOT IN (SELECT imgid FROM main.history WHERE imgid=mi.id)", and_operator(&and_term));

With no-embedded jpeg this has certainly never worked.

It would probably better to reuse the altered status.

[GrahamByrnes]

I'm probably mistaken, but wasn't this the consequence of a long discussion of what should be declared "altered"? Ie any image that has been opened was one of the proposals... so that "altered" really meant "has been looked at and been demosaiced".

But my memory is unreliable...

[phweyland]

long discussion of what should be declared "altered"?

Currently, as implemented in collect/history and on thumbnails(symbol), we have 3 cases:

• basic : only mandatory modules (note: the list may change over time)
• auto apply: modules automatically applied
• altered: manual change

For thumbnails, basic and auto apply as seen as not altered. A specific symbol for auto apply could make sense.

[johnny-bit]

In terms of select module "select unaltered" the meaning should be "without manual change" (I think)

for thumbnails: yeah, the icon could be beneficial :)

//EDIT: thanks @phweyland ! good spot!

[phweyland]

In terms of select module "select unaltered" the meaning should be "manual change" (I think)

You may have wanted to say: "without manual change"