Covid19india-react: Duplicate PATIENT NATIONALITY (India and indian)
Describe the bug
In deepdive page Patients nationality section, Indian and India are tagged as a different nationality
To Reproduce
Merge Indian and India.
- Go to 'DeepDive'
- Click on 'PATIENT NATIONALITY'
- Check India and Indian are different nationalities
Expected behavior
Both should be merged.
All Devices
ikshitiz
All 4 comments
@iKshitiz issue is with API. Kindly report the issue https://github.com/covid19india/api.
We have an issue with https://api.covid19india.org/raw_data.json API.
"nationality": "Indian"
"nationality": "India"
Both can be found here.
Nitin96Bisht
on 10 Apr 2020
I believe over here we can translate the Indian to India and then plot the chart
piyush-repo
on 10 Apr 2020
@piyush-repo Indeed we can do this but this is not the best practice approach. It is better we change the name in the excel sheet from where data is coming then it would be great.
Nitin96Bisht
on 10 Apr 2020
Avoid client side changes for this. This issue is fixed on the sheet. Thank you!
bee-rickey
on 10 Apr 2020
Related issues
abbhhiisseek
路
5Comments
Vaibhav2812
路
4Comments
DashmeetArt
路
5Comments
akshitmehra
路
6Comments
alkuhlani
路
4Comments
Most helpful comment
@piyush-repo Indeed we can do this but this is not the best practice approach. It is better we change the name in the excel sheet from where data is coming then it would be great.