Covid19india-react: Add comma separator(s) in all numerical counts

Created on 10 Apr 2020  路  6Comments  路  Source: covid19india/covid19india-react

Is your feature request related to a problem? Please describe.
Numbers written like 1000, 10000 and 100000 are difficult to read without comma separators

Describe the solution you'd like
Numbers like 1000, 10000 and 100000 should be written as 1,000, 10,000 and 1,00,000 respectively for better readability

Describe alternatives you've considered
N/A

Additional context
All numerical counts

Most helpful comment

@bee-rickey Metric system uses either dot or space to group the numbers. 1k -> 1.000 or 1 000. Do you want to go with that?
I would prefer the Indian locale for the site 10,00,000.

All 6 comments

Metric system needs to be followed on this. Avoid usage of libraries for the same. Should be a vanilla solution :)

@bee-rickey Metric system uses either dot or space to group the numbers. 1k -> 1.000 or 1 000. Do you want to go with that?
I would prefer the Indian locale for the site 10,00,000.

@KrishnaPravin How difficult would it be to change it later? The Metric system is the standard used for international numbers. So anyone using our site as a reference would be a bit confused. If it's an easy switch, lets keep the locale for now. Later take a call on metric.

@bee-rickey -- I would like to pick this up.

Hi @pb03,

As I can see every numeric data count is now separated with comma, except district wise count. Please refer below screen capture:
image

Can we have district wise data count separated by comma as well?

Thanks,
Dev

Hi @guptadev -- I have added formatting for district wise count. Please reivew and merge the PR. Thanks!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

linkwithsid picture linkwithsid  路  3Comments

Vaibhav2812 picture Vaibhav2812  路  4Comments

mohammedrehan275 picture mohammedrehan275  路  6Comments

alkuhlani picture alkuhlani  路  4Comments

srikrishnamoorthis picture srikrishnamoorthis  路  4Comments