Community: Improving Docker modules

[gundalow]

Issue to track ideas for docker modules.

May not need a full working group around Ansible & Docker, though there are some people doing good stuff and others wondering how to help.

• Update maintainers, do we want team_docker?
• Who would like to become part of team_docker?
• Identify gaps and priorities in testing, @felixfontein has been doing good work here
• What else?

Currently we have the following in BOTMETA.yml

  $modules/cloud/docker/:
    ignored: ThomasSteinbach
    notified: felixfontein
  $modules/cloud/docker/docker_container.py: $team_ansible felixfontein
  $modules/cloud/docker/docker_image.py: $team_ansible
  $modules/cloud/docker/docker_image_facts.py: $team_ansible
  $modules/cloud/docker/docker_network.py: olsaki
  $modules/cloud/docker/docker_service.py: $team_ansible

[gundalow]

@cc @danihodovic Following up on our discussions on IRC this morning I created this issue

[felixfontein]

Also CC @dariko @jwitko @kassiansun @tbouvet who are module_utils/docker_common.py maintainers and active (co-)authors of various docker_* modules.

[akshay196]

Hi team, I am currently working on a healthcheck feature(https://github.com/ansible/ansible/pull/46772) for docker_container module. Also looking forward to work on other issues after this.
If we are building team_docker, I would like to become part of a team.

[felixfontein]

Here's a list of all docker modules / plugins / module_utils with a list of active and inactive maintainers. The module_utils and connection plugin maintainers were a result of a query some time ago who wants to be notified about PRs/issues for them (#44693, #45052). These seemed to be the active maintainers and interested persons at that time :)

The classification into active/inactive is mostly over the last couple of months (i.e. since this summer). I listed everyone as active I've noticed reacting/reviewing/... something docker related.

docker_container

• active: @kassiansun @felixfontein
• inactive: @cove @joshuaconner @softzilla @zfil @dusdanig @chouseknecht

docker_image_facts

• inactive: @chouseknecht

docker_image

• inactive: @softzilla @chouseknecht

docker_login

• inactive: @olsaki @chouseknecht

docker_network

• inactive: @keitwb @chouseknecht @olsaki

docker_secret

• inactive: @chouseknecht

docker_service

• inactive: @chouseknecht

docker_stack

• active: @dariko

docker_swarm

• active: @tbouvet

docker_swarm_service

• active: @dariko @jwitko

docker_volume

• active: @agronholm

module_utils/docker_common.py

• active: @dariko @felixfontein @jwitko @kassiansun @tbouvet

lib/ansible/plugins/connection/docker.py

• active: @dariko @felixfontein @jwitko @kassiansun @tbouvet

[felixfontein]

BTW, here's a PR (adding integration tests for docker_network) which needs some help to get merged: ansible/ansible#46137

[felixfontein]

And something useful for finding PRs and issues:

• A list of all PRs per file: https://ansible.sivel.net/pr/byfile.html
• A list of all issues per file: http://ansibullbot.eng.ansible.com/ansibot/metadata/byfile_sorted.html

[felixfontein]

Maybe something about the original question by @gundalow :)

* Update maintainers, do we want `team_docker`?

I think that's a great idea! Especially since currently it's a PITA to add/update tests for modules where no maintainer is active; namespace maintainers (i.e. maintainers of other docker_* modules) count as any random other person, and so getting anything merged can take forever. Having some active people as maintainers for all docker_* modules (in form of team_docker) would simplify that a lot.

* Who would like to become part of `team_docker`?

Canonical first candidates are @dariko @jwitko @kassiansun @tbouvet (and me), as we are already on the docker_common / docker connection module maintainer list :)

Then, @akshay196 and @danihodovic have expressed interest.

Some more potential candidates: @DBendit (#35370), @ushuz (#38792)

And maybe @agronholm is still around as well?

* Identify gaps and priorities in testing, @felixfontein has been doing good work here

Having integration tests for most things is a good start. For docker_container and docker_volume, they already helped me finding several options which were not behaving as advertised...

And then there's the open list of issues and PRs. I tried to go through most docker_* PRs and give some basic feedback or ask if people are still around (if someone else didn't already do that some time ago).

[gundalow]

BOTMETA updated to define $team_docker in https://github.com/ansible/ansible/pull/47498

[gundalow]

Great work everybody.

You can see the impact by going to http://dash.tannerjc.net/graph enter repo:ansible/ansible label:docker and check backlog

• Yellow backlog line - shows backlog is reducing
• Red opened line - shows more PRs are being created (fixes, backports, etc) though you are keeping up
• purple merged line - shows merged is increasing

[gundalow]

More to do, though this issue is done.

[gundalow]

Moving to https://github.com/ansible/community/issues/408