Community: MySQL community pinboard

[dagwieers]

pinboard and wiki have been created ansible-collections/community.mysql#12 and https://github.com/ansible-collections/community.mysql/wiki/MySQL-Working-Group

[dagwieers]

cc @marktheunissen @lorin @Ernest0x @gottwald @mavimo @abondis @stijnopheide @blair @tyll @asad-at-srt @candeira @jochu @aquach @stintel @banyek @adq @bradleyy @jpmens @stoned @johnhamelink @thirty3 @tomdymond @damianmoore @pileofrogs @jhoekx @mmoya @jkleckner @Oneiroi @kustodian @ospii @gkoller @muffl0n @amree @jazmit @Jmainguy @pilou- @PierrePaul @mistaka0s @hansbaer @abeverley @adamchainz @webmat @himyouten @evgorchakov @escaped @scottbrown @caphrim007 @isegal @ghjm @wrosario

[dagwieers]

cc @georgeOsdDev @mpeters @jsmartin @jlaska @zytek @chrismeyersfsu @sbktrifork @mvgrimes @skalfyfan @bjne @megamisan @jonathonwalz @alustenberg @bobuss @computersalat @mklassen @sergey-trukhin @cdalbergue @ghost @dramaley @ilsken @willthames @zaenk @kenichi-ogawa-1988 @cosmix @MagikSquirrel @jappievw @iredmail @michalmedvecky @tolland @genofire @ChristopherGAndrews @sbktrifork @plumbeo @DSpeichert @kucuny @Xyon @Alexander198961 @chrnie @jw34 @zikalino @Uwila @oposicioncuba @oadiazp @tomaszkiewicz @bmalynovytch @mikeSimonson @diegobill @AndrewGEvans95 @timorunge @maxamillion

[dagwieers]

cc @commx @richlv @bpennypacker @uncertaintyP @MrStrix
cc: @gundalow

[dagwieers]

If you want to actively lead or are interested to be part of this Working Group, add your name to the Wiki page ! If we have a large enough group, we can start our own MySQL Working Group.

I started labeling all the MySQL related issues and PRs so we can more easily track them:

• https://github.com/ansible/ansible/pulls?q=is:pr+is:open+label:mysql (33 open PRs)
• https://github.com/ansible/ansible/issues?q=is:issue+is:open+label:mysql (62 open issues)

PS If you no longer want to receive any messages from this pinboard, feel free to unsubscribe from this issue ticket.

[genofire]

Hi, thank you to try to improve the mysql support.
I only have one problem ATM - for this i have created a PR https://github.com/ansible/ansible/pull/37400 .
I really like improve this PR if somebody take a look/review and say, what i have to do (after 11 months).

Keep calm and please accept, that i do not spent more time in developing at this project.
I wish u good luck and thank you for the initiative.

[dagwieers]

I was made aware that the ProxySQL modules made use of the MySQL module_utils. So it seems best that we add ProxySQL to the responsibility of the MySQL Working Group.

Update: I added the current WG members and added ProxySQL to the files managed by this WG. As soon as this is merged, members will have shipit rights.

[bmalynovytch]

Thank you @dagwieers for the effort.
Right now, MySQL modules suffer from many bugs, some of them required complete rewrite of the modules or libs.
We first need to determine which PRs need to be merges first and check which issues remain, as many might be closed after a couple of PRs will be merged.
Where should we talk about it ? (best place for this ?)

[Oneiroi]

@bmalynovytch https://gitter.im/ansible-mysql-wg/community I've just created this gitter room; note my BW is limited at this time I'll seek to coordinate on reviews etc as soon as I have some BW available to do so.

[bmalynovytch]

Thx @Oneiroi
If this room is fine, we should add it to the Wiki page of the WG (@dagwieers)

[dagwieers]

We are actually setting up Matrix bridges for IRC channels, so I would prefer use existing solutions for all WGs rather than individual solutions. cc @gundalow

[dagwieers]

@bmalynovytch I wouldn't mind merging all new modules as-is, if we agree to fix all issues before the Ansible 2.8 release. Which includes writing integration tests for all MySQL modules to ensure they work correctly.

[bmalynovytch]

The trouble is that most PRs will have heavy conflicts I bet.
Many of them were done based on old codebase.
I'll do my best to help but can't guarantee I'll have enough bandwidth to fix/test every module.

Couldn't we do a first review of the PRs awaiting and pick the most urgents / well reworked ?

[dagwieers]

Sure, but having integration tests helps ensure the behavior is as it was before.

PS I was only talking about new modules, not about PR's to existing modules. Those actually require integration tests beforehand IMO.

[dagwieers]

Reviewing is already possible, you don't need my approval for those ;-) (My role is a supporting one really)

[bmalynovytch]

Oh sorry, I read too quickly.
I'll give it a quick eye (Kubernetes baremetal currently deploying ^^ )

[bmalynovytch]

@dagwieers I'm unable to find PRs adding modules related to MySQL.
How do you search them ?

[gundalow]

@bmalynovytch https://github.com/ansible/ansible/labels/mysql

[bmalynovytch]

@gundalow 🤔
This search gives all issues related to MySQL, not PRs adding new modules related to MySQL.

[gundalow]

Ah, set the query to label:mysql label:new_module is:open

[timorunge]

My 2cents: KISS.

• Start with PRs which have passed checks / tests
• Start with PRs which are are easy to understand / merge, e.g.:
  
  
  
  • https://github.com/ansible/ansible/pull/19123 (Dec 2016)
  
  
  • https://github.com/ansible/ansible/pull/40183 (May 2018)
  
  
  • https://github.com/ansible/ansible/pull/47809 (mine and I really need it 😋)
  
  
• Move on, write the integration tests if they are required, prioritise the existing PRs and start to create tickets and some cleanup afterwards.

[dagwieers]

• Start with PRs which have passed checks / tests
• Start with PRs which are are easy to understand / merge, e.g.:

We don't have any real tests without integration tests, so I would really urge to start writing integration tests first. Anyone contributing to existing modules benefits from writing integration tests first to ensure/prove their changes are not breaking existing modules.

If integration tests are an afterthought, people will not be writing integration tests. Despite the fact that integration tests are really easy to make. In fact, anyone with an open PR has tested their change using a playbook, that's your integration test.

PS Currently mysql_db, mysql_user and mysql_variables have integration tests.

[dagwieers]

All members that signed up now have shipit rights and can use them to merge PRs when reviewing and testing. Use it wisely (and only after reviewing and testing).

As a result of becoming co-maintainer of the MySQL modules you will be notified by @ansibot for each open issue and PR.

We are still looking for one or more leads to manage this WG.

[bmalynovytch]

Thx @gundalow, I was missing the new_module label.
@dagwieers I'll give a look at the tests ASAP (but certainly not before a couple of days).
@timorunge I'll give them a look as well ASAP.

[bmalynovytch]

Ready for review PR (label:mysql -label:needs_rebase -label:backport status:success) : https://github.com/ansible/ansible/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+label%3Amysql+-label%3Aneeds_rebase+-label%3Abackport+status%3Asuccess

[Andersson007]

FYI: All the modules and related stuff have been recently moved to https://github.com/ansible-collections/community.mysql

[Andersson007]

FYI: pinboard and wiki have been created https://github.com/ansible-collections/community.mysql/issues/12 and https://github.com/ansible-collections/community.mysql/wiki/MySQL-Working-Group