Cockpit: Allow browser to remember login

[jniederm]

Please wrap the 'username' and 'password' input fields in login page to form tag to allow browser to remember credentials.

demo: https://jsfiddle.net/mdq538wm/1/

[stefwalter]

Cockpit is a Linux session. I guess some other Linux sessions have auto-login too, but it's usually something that's explicitly enabled per user session. This needs some thought.

@andreasn @petervo What do you think about auto-login to Cockpit using browser password caching?

[petervo]

From a linux session point of view, i don't really like it. But I'm not really able to articulate a clear reason why we shouldn't do it other than it makes me a bit uncomfortable. Unless someone else is I think it's sort of a default expectation people have in browsers these days and we should probably allow it to happen.

[martinpitt]

TBH I don't see why we wouldn't do it - the browser keyring already has all sorts of credentials and is meant for that. It's usually protected by the user's password (in most cases) already anyway, so one has to enter it at least once.

[rhwood]

FWIW, on my MacBook, running macOS High Sierra, all browsers except Firefox already offer to remember the login of cockpit running in a vagrant image (that's Google Chrome, Opera, and Safari that make the offer). Not sure if Firefox is not offering to save credentials only because the connection is not encrypted.

[rhwood]

NIST 800-63B specifically encourages supporting the use of password managers (10th paragraph).

[Limero]

This would be very useful. Those not interested in saving the login can just choose "no" when prompted by their browser.

[sergiomb2]

+1

[sergiomb2]

+1

[AndreasKieling]

+9001

[martinpitt]

I tried this again, and I can't make Firefox remember the password for the life of me. The current web page already has the required input types (text and password) for user and password lines.

I tried converting into a proper <form> and even tried to change the login button into a "submit" input (which is wrong from a UI POV, but I wanted to check if it helps). Nothing.

--- src/ws/login.html
+++ src/ws/login.html
@@ -23,7 +23,7 @@
         </div><!--/.col-*-->

         <div id="login" class="col-sm-7 col-md-6 col-lg-5 login-area" style="visibility: hidden;">
-          <div role="form">
+          <form>

             <div id="error-group" class="alert alert-danger" hidden>
               <span id="login-error-message"></span>
@@ -80,13 +80,12 @@

             <div class="form-group">
               <div class="col-md-3 col-sm-3 login-button-container">
-                <button class="btn btn-primary col-xs-12" id="login-button">
+                <input type="submit" class="btn btn-primary col-xs-12" id="login-button" translate="value" value="Log In">
                   <span class="spinner"></span>
-                  <span id="login-button-text" translate>Log In</span>
                 </button>
               </div>
             </div>
-          </div>
+          </form>
         </div><!--/.col-*-->

         <div class="col-sm-5 col-md-6 col-lg-7 details" id="login-details">

[Neustradamus]

It is an important missing feature.

[agneevX]

Any update on this issue?

[marusak]

It seems to work just fine as is.
On firefox (firefox-79.0-5) I don't get the popup, but if I click on the key icon I can save the name and passowrd:

And then on login page I can use it as expected:

Same behaviour in chromium:

I like this behaviour that the popup is not opened by default but user can find it and save the passoword. (Not sure if this was by design or not, if it was than hats off)

I would be happy if someone from this thread could also give it a shot, thanks! Closing in the meantime.

[Neustradamus]

@marusak: What is the cockpit version?

[sergiomb2]

@marusak: What is the cockpit version?

Version 226 of Fedora 31 is working

[marusak]

What is the cockpit version?

I have 227 here.

Version 226 of Fedora 31 is working

Awesome, thanks for verifying it!