Client: Weird behavior after opening an image in the help popup

[john-light]

Describe the bug
There is weird behavior after opening an image in the help popup:

• If you click an image in the help popup and then press the "x" help popup button to close it, the client crashes
• If you click an image in the help popup, right click within the help popup (but outside of the image) and press "back" then a help popup opens up within the help popup

Mainnet or testnet?
both

Expected behavior
I expect the image to popup large on my main screen, not stuck within the help popup. I also expect to be able to close the image without crashing the client or causing other buggy behavior.

Screenshots

[sohkai]

Hmm, this seems like something within HelpScout that we may want to look into. The anchor tags surrounding the images are set to open inline, rather than on a new tab or window (they're missing a target).

[AquiGorka]

@john-light it looks like you tested using a browser with a mobile viewport size right? just want to see how easy/hard this can happen in the wild.

[sohkai]

@AquiGorka This happens on desktop too; John's screenshot is just the HelpScout modal (which is a small viewport).

[john-light]

This was using the desktop Firefox browser. This bug was discovered by someone else, it is quite easy to happen in the wild if someone clicks on an image in the help documentation.

[macor161]

@john-light Do you still have this bug? I wasn't able to reproduce it with Firefox 72.0.2 on mac.

[john-light]

@macor161 I think the issue is fixed, cannot reproduce now. Will close.