Cli-microsoft365: Typo / Wrong telemetry property in the Code base for 'tenant status list' - Not a Bug - Wrong parameter / Typo
Hello,
When I was going through the code base for the command for tenant status list There is a wrong parameter given for the getTelemetryProperties method (Line No 27.)
It should have been given as
telemetryProps.workload= args.options.workload; rather than telemetryProps.sharingCapabilities = args.options.workload; which is given currently. I am assuming this may result in invalid Telemetry report if we continue with that.
This is a code change which I had done in my previous PR _Should have identified before. 馃._
Kindly feel free to assign it to me if you are fine with that.
_NB : Pardon me for the wrong template. I was not sure which template should I use in these kind of scenarios_
arjunumenon
All 5 comments
Good catch and appreciate your help! 馃憦
waldekmastykarz
on 18 Sep 2020
Good catch and appreciate your help! 馃憦
Sure @waldekmastykarz . Pleasure to help always.. Shouldn't have fallen through the crack in first place.. My bad... 馃槥.
Another question if I may; In these scenarios, say any issue / enhancement in the code base, should we use the blank template or should we use the Bug Report template. I wasn't sure what I did was correct. So wanted to confirm on that so that next time, I can follow that.
arjunumenon
on 18 Sep 2020
Not your fault, we missed it during the review as well. Seriously, no harm done.
As for the template, what you did was perfect. In fact, we could think of a template for an enhancement although they vary a lot, which is why we haven't done it yet.
waldekmastykarz
on 18 Sep 2020
As for the template, what you did was perfect. In fact, we could think of a template for an enhancement although they vary a lot, which is why we haven't done it yet.
Totally make sense. The enhancement / changes in the code base kind of request will be too specific and might not be able to create a framework template.
A wild suggestion which I can think of is, to have a template which will just give a pre-defined Title so that we can get an overall stats of those kind of requests. May be in distant future if we start analyzing the type of requests for an insight, it may be beneficial. Just a wild thought. 馃
arjunumenon
on 21 Sep 2020
Appreciate your thoughts 鉂わ笍
waldekmastykarz
on 22 Sep 2020
Related issues
waldekmastykarz
路
3Comments
vineet2907
路
3Comments
waldekmastykarz
路
3Comments
plamber
路
3Comments
garrytrinder
路
3Comments
Most helpful comment
Not your fault, we missed it during the review as well. Seriously, no harm done.
As for the template, what you did was perfect. In fact, we could think of a template for an enhancement although they vary a lot, which is why we haven't done it yet.