Cli-microsoft365: Update `approleassignment list` command to v1.0 API

[waldekmastykarz]

Related to https://github.com/pnp/office365-cli/discussions/1603

We should update the approleassignment list command to use the generally available v1.0 API.

[VelinGeorgiev]

@waldekmastykarz , @pschaeflein whoever is doing this has to make sure to test it with the object Id option.

The last time I tested the AAD Graph the objectId was referenced as objectId, but in the Microsoft Graph the objectId was referenced as id so the filter query should change from $filter=objectId eq '123' to $filter=id eq '123'

[dips365]

I would like to work on it. Can you please assign to me?

[waldekmastykarz]

All yours!

[rabwill]

Hey @dips365 , just checking in if you are still working on this?
Do let us know if you have any blockers or a question, thanks for your time 🙂

[dips365]

@rabwill I am super busy at the moment. I am not able to give contribution on this command till 15 days. So i am Un-assign my self so someone can take this up and move it forward. If this will open when i am available then i can take it up.

[garrytrinder]

Thank you for the update @dips365 and letting us know that this can be picked up by another contributor. Much appreciated, thank you 👍🏻

[pschaeflein]

I'll do it. Later this week/weekend.

[garrytrinder]

Thanks for the help @pschaeflein 👏 I've assigned to the issue to you.

[pschaeflein]

Hey team (@waldekmastykarz @garrytrinder @rabwill ),

Was there a specific choice to not include @microsoft/microsoft-graph-types in the project instead of hand-creating interfaces for Graph-supplied objects?

Also, who has most recently updated the aadapproleassigment commands? (The repo migration has truncated history.) The objects defined in the *.spec.ts files don't match my environment and I would like to chat about the app registration commands used to create them. And probably a bigger discussion around what scenarios the CLI should report on.

[waldekmastykarz]

Was there a specific choice to not include @microsoft/microsoft-graph-types in the project instead of hand-creating interfaces for Graph-supplied objects?

I don't think it was a conscious decision on our part. In many cases, there would be a little added value for us as we're not working with all properties. Also, we're switching a lot between v1.0 and beta endpoints which means that we could have a case where the particular property is not present on the object anyway. So until now, we've been creating interfaces with just the properties that we use rather than all properties that are available on the object. Does that make sense?

Also, who has most recently updated the aadapproleassigment commands?

Looking at the commits and issues it seems like @VelinGeorgiev and yourself worked on these commands. If there are specific issues, let's create an issue/discussion and take it from there.

Appreciate your help! 👏

[pschaeflein]

With the release of PowerShell and the upcoming CLI, I will not be moving forward on this issue.

[waldekmastykarz]

OK, thanks for the update @pschaeflein

[aakashbhardwaj619]

Hi Guys, I would like to work on this.

[garrytrinder]

Thank you for the help @aakashbhardwaj619 its all yours 👍🏻

[waldekmastykarz]

Awesome @aakashbhardwaj619. Appreciate your help 👏