Clarity: Combobox: Ability to disable browser autocomplete for input

Created on 20 Aug 2020  路  4Comments  路  Source: vmware/clarity

Describe the bug

In combobox I get the browser autocomplete/autofill in addition to the combobox autocomplete.

How to reproduce

Go to https://clarity.design/documentation/combobox and have autofill/autocomplete active in your browser.
Bildschirmfoto 2020-08-20 um 09 01 33

After hitting ESC it shows the combobox autocomplete:
Bildschirmfoto 2020-08-20 um 09 01 39

Expected behavior

Browser autocomplete/autofill should be disabled for the combobox input or is there any usecase to leave it enabled?
see https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion

Alternatively this attribute should be controllable via @Input parameter.

Versions

App

  • Angular: 10
  • Clarity: 4

Device:

  • Type: iMac
  • OS: macOs
  • Browser: chrome
  • Version: 84.0.4147.125
combobox bug v4

Most helpful comment

Unless autocomplete is explicitly set to off, a combobox has multiple lists of completion: a list from clr-options; and a list from browser suggestion.
From the screenshots, a browser suggests values such as 12,99... and it completely hides clr-options. As a combobox does not accept free user input and a user has to select from clr-options, I do not prefer displaying browser suggestion as a primary option and I expect autocomplete to be off by default.

Other products provide auto complete functionality and set autocomplete to off.

All 4 comments

I can't think of a valid reason the autocomplete should not be set to false. If there is a use case as stated above we could expose it as an input prop.

Unless autocomplete is explicitly set to off, a combobox has multiple lists of completion: a list from clr-options; and a list from browser suggestion.
From the screenshots, a browser suggests values such as 12,99... and it completely hides clr-options. As a combobox does not accept free user input and a user has to select from clr-options, I do not prefer displaying browser suggestion as a primary option and I expect autocomplete to be off by default.

Other products provide auto complete functionality and set autocomplete to off.

Resolved by #5000

Hi there 馃憢, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

Was this page helpful?
0 / 5 - 0 ratings