Clarity: Popover pointer not inheriting color correctly

Created on 17 Jul 2020  路  1Comment  路  Source: vmware/clarity

Describe the bug

The popover pointer on the signpost uses a border-right: 0.6rem solid white; to get its color. It should instead use some CSS property (when enabled) to set the color (in the case of the default theme white). This breaks theming of the signpost when a user is using CSS properties.

How to reproduce

https://stackblitz.com/edit/clarity-v3-light-theme-b8kbka?file=angular.json

  1. Open the signpost
  2. Inspect the .popover-pointer:before element
  3. See that the border-right uses the fixed color of white whereas on the .signpost-wrap the background-color uses some CSS property.

Expected behavior

The .popover-pointer:before element should be theme-able using CSS properties.

Versions

App

  • Angular: 9
  • Node: 12
  • Clarity: 3.0.0

Device:

  • Type: Macbook
  • OS: Catalina
  • Browser Chrome
  • Version 83.0.4103.116
@clangular signpost bug

Most helpful comment

Assigning to myself, as I am currently working on some signposts changes.

>All comments

Assigning to myself, as I am currently working on some signposts changes.

Was this page helpful?
0 / 5 - 0 ratings