Clarity: Dark Theme: loading state backdrop color doesn't match dark colors palette

Created on 20 Dec 2017  路  7Comments  路  Source: vmware/clarity

Select one ... (check one with "x")

[x] bug
[ ] feature request
[ ] enhancement

Expected behavior


screen shot 2017-12-20 at 10 16 07 am

Suggested behavior

The suggestion color is to use rgba(24,24,24,0.5); @lil-kim does this meet our accesability standard?
screen shot 2017-12-20 at 10 17 43 am

Environment details

  • Angular version: 4.x.x

  • Clarity version: @latest

  • OS and version: All

  • Browser: [all]

Dev

Most helpful comment

@lil-kim 0.5 looks OK...

screen shot 2017-12-20 at 12 31 14 pm

regarding accessibility, I think @hippee-lee is more talking about the ability to read the text underneath the backdrop, i.e. column headers... personally, I don't think it's that important, the whole point of the backdrop is to obscure the text a little bit.

All 7 comments

Hi @hippee-lee ,
For consistency, can we use the same backdrop we have when the wizard pops up?
It's rgba 0, 0, 0, 0.85.
re: accessibility, it's only really required for text (at least, to my knowledge). This is a large graphic so it shouldn't be an issue.

@lil-kim it's pretty dark...
screen shot 2017-12-20 at 12 23 02 pm

@elesueur Can you try 0, 0, 0 at 50%?

@lil-kim 0.5 looks OK...

screen shot 2017-12-20 at 12 31 14 pm

regarding accessibility, I think @hippee-lee is more talking about the ability to read the text underneath the backdrop, i.e. column headers... personally, I don't think it's that important, the whole point of the backdrop is to obscure the text a little bit.

LGTM. I agree the text doesn't have to - actually can't - be accessible for this to look like a background overlay.

Sounds like we are going with 0, 0, 0 at 50% for the datagrid loading color.
Thank you both.

Hi there 馃憢, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

Was this page helpful?
0 / 5 - 0 ratings