Circuitverse: Add link to project page in simulator
Add a link to redirect to project page directly from the simulator.
Please send PR to new_UI branch.
satu0king
All 9 comments
can i work on this feature
GAUTAMSAHARAN
on 1 Oct 2020
can i work on this feature
Go ahead!
satu0king
on 1 Oct 2020
should I directly put href in tag or we need to go with creating function in js just like with other options in dropdown.
GAUTAMSAHARAN
on 1 Oct 2020
One more thing, rather than adding another option in menu how about we put link directly on project name in the navbar
GAUTAMSAHARAN
on 1 Oct 2020
I have created this feature i put link on the project-name in simulator page, and made a pr . Please review it.
GAUTAMSAHARAN
on 1 Oct 2020
One more thing, rather than adding another option in menu how about we put link directly on project name in the navbar
Interesting, However, I think it is better if we add the hyperlink on a icon like this.
@Shivansh2407, @sal2701 any inputs?
satu0king
on 1 Oct 2020
What i think is we don't have any kind of icon in whole nav-bar so it looks bit different, and usually we reach to our desired location by clicking on main title, that's my thought.
GAUTAMSAHARAN
on 1 Oct 2020
What i think is we don't have any kind of icon in whole nav-bar so it looks bit different, and usually we reach to our desired location by clicking on main title, that's my thought.
Agreed with your point on the icon. However, there is another feature coming in soon letting users edit the the project name by clicking on the project name (Like in google docs). This feature takes precedence over yours. Moreover, the userwill not expect the project name to be a hyperlink. I think for now just add the hyperlink to the drop down. We can always move it as we improve. Thanks!
satu0king
on 1 Oct 2020
ok, I understand and I put a hyperlink in dropdown menu rather than in project-title. Now you can review my PR. Thanks for your help.
GAUTAMSAHARAN
on 1 Oct 2020
Related issues
mahmodHammad
路
8Comments
satu0king
路
5Comments
tachyons
路
7Comments
ankitkataria
路
5Comments
ankitkataria
路
4Comments
Most helpful comment
Agreed with your point on the icon. However, there is another feature coming in soon letting users edit the the project name by clicking on the project name (Like in google docs). This feature takes precedence over yours. Moreover, the userwill not expect the project name to be a hyperlink. I think for now just add the hyperlink to the drop down. We can always move it as we improve. Thanks!