Circuitverse: Empty group member list gives success message

Created on 27 Feb 2019  路  4Comments  路  Source: CircuitVerse/CircuitVerse

Adding group members without any emails shows the success message that a groups member has been added. It should show an error message regarding the empty email field.
Similar issue occurs while adding collaborators.

All 4 comments

I would like to self assign this issue. :slightly_smiling_face:

I would like the message to show the following details.

  • [ ] Number of emails newly invited
  • [ ] Number of emails already invited
  • [ ] Number of emails failed (email is not actually an email)

For checking if the email given is an email, right now, the system doesn't parse the email strings to check if the string is actually an email. You will need to implement this.

We can use validates :email, format: { with: URI::MailTo::EMAIL_REGEXP } in the required models to check the emails.

We can use validates :email, format: { with: URI::MailTo::EMAIL_REGEXP } in the required models to check the emails.

This is good, but we might not want to create a PendingInvitation record in the first place if the email ID is incorrect.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

darkshredder picture darkshredder  路  8Comments

MrBartusek picture MrBartusek  路  8Comments

sal2701 picture sal2701  路  9Comments

mahmodHammad picture mahmodHammad  路  8Comments

ryuk156 picture ryuk156  路  9Comments