Circuitverse: Handling schema.rb in version control

Created on 9 Mar 2019  路  5Comments  路  Source: CircuitVerse/CircuitVerse

It is generally recommended to commit schema.rb file along with other file systems as mentioned here
Will it be a good idea to remove it from .gitignore and commit it for our project too?

triage

Most helpful comment

@ankitkataria We are.

All 5 comments

I suppose it wasn't done in the past to stay away from merge conflicts but that is not the way we should go forward. I agree of having schema.rb in our version control.
@tachyons would be the best person here to respond to this.

Thanks for the suggestion.

Yes, it is the recommended practice, but it is impossible to have schema.rb in version control since we support two databases at the moment. We can add them once we drop mysql support

I agree, the extension mentioned in the file would differ. Are we planning to drop mysql support anytime soon?

@ankitkataria We are.

I'll add the schema.rb once Issue #234 is done.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

tachyons picture tachyons  路  6Comments

MrBartusek picture MrBartusek  路  8Comments

ryuk156 picture ryuk156  路  4Comments

mahmodHammad picture mahmodHammad  路  8Comments

ankitkataria picture ankitkataria  路  4Comments