Cataclysm-dda: Missing roof on laundromat

[ashGlaw]

Describe the bug

The laundromat spawns without a roof. Saving and loading with it in the reality bubble generates a roof, but it has no furniture.

Steps To Reproduce

Start a new character. Debug reveal the map and search for a laundromat. If you don't find one you'll need to teleport outside of the revealed area and reveal the map again until you find one. Long range teleport to within a few overmap tiles from it, distance isn't important as long as it's outside of the reality bubble. Walk on over to the laundromat and observe its lack of roof. Save. Load your save. The roof is there, but incomplete.

Expected behavior

The laundromat should spawn with it roof on, and there should be roof furniture up there like the gutters to match the drainspout a z-level down.

Screenshots

Laundromat roof before save

Laundromat roof after load

Versions and configuration

• OS: Windows 10


• OS Version: 10.0 1909


• Game Version: 0.D-12499-gcbd994a [64-bit]


• Graphics Version: Tiles


• Mods loaded: [
  
  Dark Days Ahead [dda],
  
  Magiclysm [magiclysm],
  
  No Rail Stations [No_Rail_Stations],
  
  SpeedyDex [speedydex],
  
  Stats Through Kills [stats_through_kills],
  
  Stats Through Skills [StatsThroughSkills]
  
  ]

[Funguss]

I've noticed a few buildings still without roofs, I assumed they just hadn't been gotten to yet. Should we have a report with a checklist to keep tabs?

[curstwist]

I've noticed a few buildings still without roofs, I assumed they just hadn't been gotten to yet. Should we have a report with a checklist to keep tabs?

report them. Almost all have been done. I have a list so I can compare it and see if something wasn't linked properly.

Or, go look in either multitile_city_buildings.json (or specials.json) and overmap_terrain_xxxx for their entries and if they are missing, add them.

[Funguss]

Just done a check on ones I could remember, but they seem to be fine now. What I was trying to get at was if we needed to open a new issue for each and every occurrence, which seemed like a bit of a headache.

[curstwist]

Just done a check on ones I could remember, but they seem to be fine now. What I was trying to get at was if we needed to open a new issue for each and every occurrence, which seemed like a bit of a headache.

you could put several in one issue.
for mapgen basics (which files do what & why) you can look at the beginner's guide I added. If you'd like to learn more. Only identifying problems is fine though.

For roofs in particular, if you try to go up and the stairs try to kill you or you get an error. That's a good sign. Also, they won't get gutters or other additions like is mentioned in this issue.

[Funguss]

Ah, nice one, I'll give that a look tomorrow! Right now it's going straight over my head I'm afraid.

[curstwist]

sure. it isn't your responsibility to identify all the roof problems : ). It sounded like you already had a list earlier.

[Funguss]

Ah, no, just a mental one. I spoke up without considering the last instance I saw, which was prior to the font changes (I didn't update until they were fixed, I simply couldn't bring myself to play with that font). IIRC there were a few additions during that time which must have fixed all the ones I'd seen. The original lab was the one that stuck out most, but that may have been done for a long time. I've not had a game reach any kind of lab in quite a long time.

[Funguss]

Ah, right, so roofs without gutters and such are ones that need some work? Somehow that went straight over my head. In that case there are a few I know of, though finding them now will be slightly more troublesome.

Original style lab entrances are one, though I have no idea where they're located in the jsons. They don't seem to be anywhere that I can tell.

The neo-whatsit faction's... um... tree farm? The one with the friendly cyber dogs? That didn't have a roof IIRC.

There's at least one city gas station, too, it has three gasoline pumps, a toilet out back, and a large windowed office type space along with a small shop.

Jewellery stores with the blue walls.

Refugee centre.

Apple orchard stall and tree farm (the latter almost got me killed! So I map edited one in).

Used bookstore, though this is a Magiclysm addition IIRC so I'm not sure if it's within your scope.

That's about all for now, but I'll definitely keep my eyes peeled.

[curstwist]

Ok thanks, I knew about some but I'll check the others out. Can add cathedral to your mental list. I think thr cyber dogs must be a mod too.

[Funguss]

Yeah, probably aftershock. Cathedral roofs should be very interesting, depending on the style. I must admit I don't know what American cathedrals look like, let alone New England ones.

Edit: That tree farm nearly got me killed by beavers I might add. Those things are downright homicidal. I thought beaver attacks were supposed to be rare? They're worse than feral dogs!

[curstwist]

further discussion on these issues should move to a new issue or be covered in a more casual venue like the development discord. This single issue is fixed and should be closed since it's resolved.