Cataclysm-dda: [$25] Please restore Mouse View functionality to the sidebar

[junkyjb]

Please restore Mouse View functionality to the sidebar.

Prior to the new customisable sidebar layout Mouse View used to appear whenever the mouse was moved from the sidebar into the main window, temporarily covering the compass and part of the message log.
It automatically disappeared upon movement of the player character, or the mouse returning to the sidebar.

If the old method of displaying it isn't possible under the new layout please could it be added as an optional panel in the sidebar.
(It could default to off, if you are concerned about preventing clutter in the default view)

I'm aware we can still use mouse look via opening the Look Around pop-up menu with ; or x, however this adds unnecessary repeated keystrokes, including having to press ESC to close the pop-up, each time we start and finish looking around.

Versions and configuration(please complete the following information):

• OS: Windows 7
• Game Version: 0.D-841-g462722b
• Graphics version: Tiles

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ImportTaste]

@kevingranade It's concerning that there hasn't been any recent activity on this. I think the lack of activity results from what you said on the reddit: https://www.reddit.com/r/cataclysmdda/comments/b34nss/mouse_look/eixo87q/

I really miss this feature, can you please look into it?

[ImportTaste]

@kevingranade Could these be the culprit?

https://github.com/CleverRaven/Cataclysm-DDA/commit/2636a0e5be1e92711fb46b78c3be0c21518cc062#diff-18513665750ef5adf42b5ec29e14162eL2286

https://github.com/CleverRaven/Cataclysm-DDA/commit/2636a0e5be1e92711fb46b78c3be0c21518cc062#diff-18513665750ef5adf42b5ec29e14162eL2290

EDIT: I was expecting those to embed but I guess the diff is too large for Github to bother. The second link is just 4 lines down from the first.

[esotericist]

This is something I meant to sort actually months ago, but it slipped my mind. I'll try to get this sorted soon.

[Xan-Kun]

Any news? It's not working in 0.D-7411-g92a1956.

[Hypertyrannical]

@kevingranade Could these be the culprit?

2636a0e#diff-18513665750ef5adf42b5ec29e14162eL2286

2636a0e#diff-18513665750ef5adf42b5ec29e14162eL2290

EDIT: I was expecting those to embed but I guess the diff is too large for Github to bother. The second link is just 4 lines down from the first.

I'm curious too, did this turn out to be the issue? I've been wanting this fixed since the day it was broken.

[mouseturd]

Bounty reward for this: https://www.bountysource.com/issues/71726642-please-restore-mouse-view-functionality-to-the-sidebar

[esotericist]

Belated update: I have a pretty good idea what needs to be done, but my primary development machine is being uncooperative.

The short version, in case someone else is feeling adventurous, is that the actual "mouse look" window is no longer being invoked. the code that was responsible for that was tied into the sidebar rendering invocation, which works entirely differently in the current codebase due to the new sidebar. The support code for it still technically exists, but it doesn't get called anymore.

Fixing it is unfortunately not something that can be done by reverting a couple of lines. At minimum, we need to find a new entry point to invoke the old code. A more proper fix would involve unifying the "mouse look" functionality and the "look around" functionality we have in the x look around state family, since those were apparently completely disconnected even in 0.D stable.

This logic duplication is undesirable and should be fixed, but a stopgap that just gets the functionality restored should still be acceptable.

[MetalSpork]

I'll throw in for an extra $5. https://www.bountysource.com/issues/71726642-please-restore-mouse-view-functionality-to-the-sidebar

[Rhiawhyn]

Soon
Months later

If you have a stopgap fix it should be possible to apply it, if it works woo fixed and functional until the proper one can be done. But it's been quite some time so at some point _something_ has to be addressed.

[RoyBerube]

Just noticed a small bug with the mouse view code that it was displaying one row too few and truncating the last row. I've sent a pull request and it should be merged by tomorrow as it was a simple fix.