Cataclysm-dda: Melee Weapon Training trait not giving prompt to choose style

[JoaoMagal]

Describe the bug
Exactly title. After creating the character, when you start the game, it gives no prompt to choose between the 6 melee weapon styles. Probally is mod-related, seeing that I am using the Medieval and Historical Content mod and the character starts with the Medieval Swordsmanship style.

To Reproduce
Create a character with the Melee Weapon Training trait, on a world with the Medieval and Historical Content mod.

Expected behavior
A prompt should appear, giving the choices of martial arts you can chose.

Versions and configuration(please complete the following information):
Windows 10, Experimental 8476, Tiles.
Mods:
"dda", "craftgp", "safeautodoc", "brightnights", "FIC_Weapons", "realguns", "growable-pots", "ew_pack", "makeshift", "Medieval_Stuff", "More_Survival_Tools", "nw_pack", "more_classes_scenarios", "filthy_morale", "manualbionicinstall", "sleepdeprivation", "StatsThroughSkills"

Additional context
On a side note, fix the Medieval Stuff's Melee Weapon Training description to also show Sojutsu and Niten Ichi-Ryu as possible weapon styles.

[JoaoMagal]

27831 is also related to this. Seems the problem really is mod-related.

[JoaoMagal]

Upon further examining the mutations.json from Medieval_Stuff, it seems that two traits are getting replaced: Martial Arts Training and Melee Weapon Training, because of the addition of Pankration and Medieval Swordsmanship.
In fewer words, those two traits are getting replaced by the mod, instead of getting those martial arts and adding them to the trait.

        "type" : "mutation",
        "id" : "MARTIAL_ARTS",
        "name" : "Martial Arts Training",
        "points" : 3,
        "description" : "You have received some martial arts training at a local dojo.  You start with your choice of Karate, Judo, Aikido, Tai Chi, Taekwondo, or Pankration.",
        "starting_trait" : true,
        "initial_ma_styles" : [ "style_pankration" ],
        "valid" : false
    },{
        "type" : "mutation",
        "id": "MARTIAL_ARTS5",
        "name": "Melee Weapon Training",
        "points": 3,
        "description": "You have practiced fighting with weapons.  You start with your choice of Eskrima, Fencing, Pentjak Silat or Medieval Swordsmanship.",
        "starting_trait" : true,
        "initial_ma_styles" : [ "style_swordsmanship" ],
        "valid" : false

Core game code:

        "type" : "mutation",
        "id" : "MARTIAL_ARTS",
        "name" : "Martial Arts Training",
        "points" : 2,
        "description" : "You have received some martial arts training at a local dojo.  You start with your choice of Karate, Judo, Aikido, Tai Chi, or Taekwondo.",
        "starting_trait" : true,
        "initial_ma_styles" : [ "style_karate", "style_judo", "style_aikido", "style_tai_chi", "style_taekwondo" ],
        "valid" : false

        "type" : "mutation",
        "id": "MARTIAL_ARTS5",
        "name": "Melee Weapon Training",
        "points": 3,
        "description": "You have practiced fighting with weapons.  You start with your choice of Eskrima, Fencing, Pentjak Silat, Niten Ichi-Ryu, or Sōjutsu.",
        "starting_trait" : true,
        "initial_ma_styles" : [ "style_eskrima", "style_fencing", "style_silat", "style_niten", "style_sojutsu" ],
        "valid" : false

Side-note: The MARTIAL_ARTS trait in the core game costs 2 points, wheras in the mod costs 3.

[ifreund]

In fewer words, those two traits are getting replaced by the mod, instead of getting those martial arts and adding them to the trait.

I think you're 100% right about whats happening here. Since this is the 3rd issue to be opened for the same bug, I'll open a PR to fix this in just a minute.