Cartodb: Disable DO for users without quota

[javitonino]

From @noguerol in https://github.com/CartoDB/bigmetadata/issues/230#issuecomment-322814359

To be confirmed: does the credit removal enables DO access to free and personal accounts? In case it does we should prevent it.

I tested this change (master) and it seems to open DO for everyone, including users with DO quota = 0. As we block in the backend side, users will get all requested values as null.

The desired behaviour is:
obs_general_quota = 0 && soft_limit = false -> Upselling message (or maybe analysis disabled)
obs_general_quota >= 1 || soft_limit = true -> No quota checking

cc @nobuti @xavijam

[nobuti]

Do we have any screen to follow @CartoDB/design?

[xavijam]

Uhm... there is no upgrade state for disabled analyses. About the other thing, there was a decision about opening DO for everybody, what did happen with that? @noguerol @kevin-reilly

[ethervoid]

@xavijam as @noguerol not for everyone: https://github.com/CartoDB/cartodb-platform/issues/3547 and he best way to block them or show an upselling message is when they're going to select DO analysis

[xavijam]

Mates, there is no such "upselling" thing, either designed or implemented (or taken into consideration). Why are we adding that now?

[noguerol]

Let's continue this conversation here: https://github.com/CartoDB/cartodb-platform/issues/3547

[juanignaciosl]

@xavijam final decision (see CartoDB/cartodb-platform/issues/3547#issuecomment-325320198):

obs_general_quota = 0 && soft_limit = false -> Hide analysis
obs_general_quota >= 1 || soft_limit = true -> No quota checking

Let me know if you need anything from our side. This is the last step before public release 🤗

cc @jorgesancha @kevin-reilly @noguerol

[xavijam]

:+1:

[juanignaciosl]

@xavijam this is already deployed, isn't it?

[xavijam]

Yes

On 31 Aug 2017, at 08:52, Juan Ignacio Sánchez Lara [e-mail] wrote:

@xavijam this is already deployed, isn't it?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[nobuti]

Already in production. Closed by https://github.com/CartoDB/cartodb/pull/12682.