Cartodb: GitHub auth not working on sign up page

[santisaez]

Steps:

1) Go to https://carto.com/signup
2) Click on GitHub button
3) Log into GitHub (tested with an account with two-factor auth enabled)
4) You will be redirected to https://carto.com/github?code=xxx&state=yyy

The sign-up form does not appear.

SMOKE_OB03

[javitonino]

Hey, I talked with Santi and it actually works. He was being redirected to the signup flow because he didnn't have an account linked with that GH email. The screen he gets is:

Asking him to choose another username, as the one in GitHub is already taken. We tested signup and then login and it worked.

The only thing here, is that it may be unclear that the screen is asking you to choose another username in order to sign up. @CartoDB/design do you think we need to do some change here? Otherwise, let's close this.

[arianaescobar]

We could add a red tooltip (like the one we use in the Builder) instead of that ! to indicate the error explicitly.

@carlostallon any idea?

[carlostallon]

Now we are showing a tooltip when hover the red circle

but, to make it clear what do you think to show the error this way?

[arianaescobar]

yup, that was my suggestion :)

[javitonino]

cc @MariaCheca