Cartodb: Double click anchor point on drawn line/polygon to remove point

[zingbot]

Context

Drawing or editing a polygon (or line)

Steps to Reproduce

1. Draw an object, either a line or polygon
2. identify an anchor point to remove
3. double-click the point to remove it

Current Result

no effect

Expected result

Anchor point is removed

Browser and version

Chrome

Additional info

Did we remove this?

[xavijam]

cc @alonsogarciapablo @rochoa

[alonsogarciapablo]

Did we remove this?

I'm not sure if this worked in the previous version of our product, but I'm pretty sure we haven't implement this yet on BUILDER.

[benwa]

Deleting anchor points would be a very appreciated feature. Whether the UX is to double click, hold ALT/CTRL/SHIFT, or a dedicated button wouldn't matter to me, I just need something.

[noguerol]

Ping

[elenatorro]

To add this feature, I think it would be needed to update carto-zera in order to support double click events. I would like to discuss this change with @ivanmalagon @IagoLast and @rjimenezda before continuing with this issue :)

[IagoLast]

in order to support double click events

LGTM but I think we need to discuss the new events.

We have 2 new cases:

• double-click inside a feature
• double-click outside a feature

Since we wanted to keep the old wax api you have 2 kinds of events: on and off.

on event is fired when the user clicks or moves the mouse inside a feature while off is fired when the user clicks or moves the mouse outside a feature.

To distinguish between them event.type is used.

IMO we should add a new event.type called dblclick and follow the same pattern.

feel free to ask if you have doubts, but it shouldn't be hard

[ramiroaznar]

We are going to implement this again. cc @alonsogarciapablo @csobier

[zingbot]

Thank you so so much for pushing this forward. I have three customers who have been struggling with this.

[elenatorro]

About this issue:

1. The fix in https://github.com/CartoDB/cartodb.js/pull/2017 adds the feature of deleting an anchor when the geometry is in edit mode, not when it is being created.

2. When closing this issue, I will open another one to support deleting anchors when creating a geometry.

3. However, there is a bug (https://github.com/CartoDB/cartodb/issues/13423) when creating a geometry: it does not let you enter in edit mode after saving the geometry unless you refresh the page.

I think we should close this issue with the feature described in point 1, and solve the bug described in 3 before continuing with 2.

What do you think? cc @alonsogarciapablo @ramiroaznar

[ramiroaznar]

Works for me.

[alonsogarciapablo]

👍

[ramiroaznar]

:boom:

[xavijam]

BOOM!