Calculator: Code Cleaning: AppBar, OperatorTextBox and OperandTextBox, TitleBar never used
Cleaning
The 3 following controls in Calculator/Controls are never used in the application.
- AppBar: https://github.com/Microsoft/calculator/search?q=AppBar&unscoped_q=AppBar
- OperatorTextBox: https://github.com/Microsoft/calculator/search?q=OperatorTextBox
- OperandTextBox: https://github.com/Microsoft/calculator/search?q=OperandTextBox
TitleBar and TitleBarHelper are used in different parts of the application (Memory, HistoryList, ...), but it seems like these controls have no effects on the app (old code from Windows 8/Windows Phone 8.1?)
rudyhuyn
All 10 comments
This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.
MicrosoftIssueBot
on 29 Mar 2019
Do those controls needed to be removed? If yes. can I do it?
jatinkumarg
on 31 Mar 2019
Do those controls needed to be removed? If yes. can I do it?
Hi @jatinkumarg! Of course you can, but Microsoft must first check and accept (or decline) this issue. Look at labels in the right column, it's currently "triage needed", you can start working on it once triage approved added.
(The cleaning should also include the only used by these controls).
rudyhuyn
on 31 Mar 2019
@jatinkumarg, good news, this task has been approved, do you still want to do it?
rudyhuyn
on 4 Apr 2019
@rudyhuyn yeah!
jatinkumarg
on 4 Apr 2019
@rudyhuyn I have added my PR. Can you please review it?
Do you also want me remove the TitleBar and TitleBarHelper?
jatinkumarg
on 5 Apr 2019
We should ask @grochocki. Do you have any plan with Titlebar/TitlebarHelper or is it a "relic" from the past (w10m?)?
rudyhuyn
on 5 Apr 2019
The TitlebarHelper code is for compact layout when the History/Memory flyouts are opened. They let you click and drag the titlebar without dismissing the flyout.
danbelcher-MSFT
on 5 Apr 2019
@danbelcher-MSFT
The main reason you can't drag and drop is partially caused by the "fix" (TitleBar/TitleBarHelper and all Border named "CustomTitleBar" blocking pointer events), I will push a PR tonight cleaning all that and still letting you to drag and drop the window when the flyout is opened
rudyhuyn
on 5 Apr 2019
The TitleBar usercontrol is because we briefly experimented with having a button in the About page that allowed users to opt-in/out of experimental content. It was a legal requirement that the titlebar updated to reflect if they were in an experimental build or not. Since we aren't doing that anymore, it should be fine to remove the usercontrol.
danbelcher-MSFT
on 6 Apr 2019
Related issues
grochocki
·
25Comments
LanceMcCarthy
·
17Comments
MicrosoftIssueBot
·
19Comments
InfoLibre
·
17Comments
imchau
·
27Comments
Most helpful comment
@rudyhuyn yeah!