Calcite-components: Split Button Enhancements

Created on 9 Jun 2020  ·  8Comments  ·  Source: Esri/calcite-components

  1. Appearance for entire button: clear|transparent|...
  2. Separate appearance attribute for primary
  3. Separate disabled attribute for primary

Simulation of what we would like to be able to achieve:

  • Primary disabled but dropdown still active
    image
  • User made changes, primary is enabled
    image

  • User clicked primary, we replace the icon
    image

  • At the end of the process we briefly show the check, we replace temporary the icon
    image

/cc @bpatterson88

Stale enhancement help wanted

All 8 comments

Yep - these are good enhancements.

  • User clicked primary, we replace the icon
    ![image](https://user-images.githubusercontent.com/3506166/84091624-dc5ef800-a9a9-

For this one, you use the loading prop correct? and then replace the primary-icon with the "success check" before reverting back to the initial save icon?

would like to get the outline version to look more like this

@macandcheese

image

i know we tried to avoid using non-buttons, but... the triple border in the other screenshot above is odd. can we achieve this with the button component?

@macandcheese My mistake.
For:
image
You are correct I meant to say 'set loading to true'

@bstifle likely not with just the components but we can probably fudge it in some way.

awesome, thanks adam

@macandcheese additional thing about loading...
I did not test but I would expect that the button is from an event standpoint of view disabled.
Not visually thou.
I think that the disable visual state is not helping during these transitions.
Hopefully I'm making sense.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

This issue has been automatically closed due to inactivity.

Was this page helpful?
0 / 5 - 0 ratings