Cacti: Modify automation to test for data before creating graphs

[cigamit]

Some templates and automation routines are quite ignorant of the fact that some OID's do not exist, but create the graphs anyway. We should always test the data source before creating it.

[eschoeller]

Hey @TheWitness maybe #4182 fixed this?

[TheWitness]

No, but give me few days, on a streak.

[eschoeller]

Lol yeah you are!

No rush on this one from my end. Just happened to notice it and it sounded similar enough to the other issue.

[TheWitness]

@eschoeller, can you please test these. I need Data Queries tested. I've tested script and snmp, and they both appear working just fine. Note, remote agent is not functional yet. So, no remote data collectors unless the main Cacti can reach the devices.

[anarkia1976]

Hi, i have these errors:

2021-03-25 12:04:22 - CMDPHP PHP ERROR NOTICE Backtrace: (/host.php[70]:form_actions(), /host.php[327]:automation_update_device(), /lib/api_automation.php[3953]:automation_execute_data_query(), /lib/api_automation.php[2206]:create_dq_graphs(), /lib/api_automation.php[2618]:test_data_sources(), /lib/functions.php[1594]:test_data_source(), /lib/functions.php[1784]:CactiErrorHandler())
2021-03-25 12:04:22 - ERROR PHP NOTICE: Undefined variable: outputs in file: /var/www/html/cacti/lib/functions.php on line: 1784

the problem arises when automation has to create graphs related to firewall interfaces. (atuomation --> graphs rules).

thanks a lot.

[TheWitness]

@anarkia1976, thanks for testing. Update soon.

[TheWitness]

Try again.

[anarkia1976]

Error attached:

thanks.

[eschoeller]

Sorry I'm not in the greatest position to test right now ... only have a prod environment that is ... running on questionable/overloaded hardware (I guess?). New hardware upgrade coming ...

[TheWitness]

One step closer. Next commit should fix it the rest of the way.