Buttercup-desktop: Windows binary code signing

[perry-mitchell]

We should be codesigning our build on Windows before releasing.

[perry-mitchell]

Links:

• Electron builder code signing
• Comodo certs

[ghost]

The code signing _issue_ with Electron been taken up already earlier, not?

https://github.com/electron-userland/electron-builder/issues/3188

Just tested a new build with _signAndEditExecutable: false_, and it worked! It seems that whatever that process is doing is breaking the build under Mac.

How should we move forward?

EDIT: On a related note, what exactly does that flag do? Is it harmful to have it set to false in production?

[jenstornell]

Maybe this comment https://github.com/buttercup/buttercup-desktop/issues/690#issuecomment-442603899 belongs here as well:

[perry-mitchell]

Certificate purchase is underway.. Just waiting for the validation to be completed.

[perry-mitchell]

Validation complete - Now we just need to add the signing process to the desktop build procedure.

[sallar]

Windows is code signed and released: 1.14.0 :)

[ghost]

Looks like it does not make a difference with Defender's SmartScreen. Maybe the certificate needs to get propagated into the MS database.

[sallar]

@n8v8R this warning will go away once more users start to install it. It shows our company name now. But because it’s not a EV (expensive) cert it will take a while to be fully trusted :)