Buildinggadgets: Placing Windows form Macaw's Windows makes a water source

[Coldphoenix94]

IMPORTANT: Before continuing, please ensure that Building Gadgets (and any other mods involved) is updated to the latest available version

After deleting this template, please provide the following information:

• Forge version 35.1.15
• Building Gadgets version 3.7.3
• If the issue is a crash; An external link to the crash report
• How to reproduce the issue Placing a Diorite Tall Windows with the Building Gadjet
• A screenshot, if applicable https://imgur.com/a/zib20Ek

It makes a water source insite the window. Breaking the windows does not remove the water source. Kind of weird one

[MichaelHillcox]

@hvdklauw this one might be for you

[hvdklauw]

Haha, yeah sounds familiar, let's have a look at their default state

[hvdklauw]

Hmm can't find the source :(

[Hanawa02]

The same happens for Illuminant Panel, Illuminant Fixture and Illuminant Slab from the Simply light mod.

[hvdklauw]

Ok, maybe we should just always force waterlogged to false :S

[MichaelHillcox]

So many mods do this wrong apparently :P

[Staegrin]

Also caused when pasting Dark Shingle Roof from engineer's decor.
Only the normal variant and not the one with a chimney or window in it.
Minecraft: 1.16.5
Forge: 36.0.1
engineer's decor version: engineersdecor-1.16.4-1.1.7
building gadgets vesion: buildinggadgets-1.16.4-3.7.3

[hvdklauw]

Tomorrow I'll just force the waterlogged to false on all the blocks, water is cheap unless you have a really weird modpack in which case we might not want to duplicate it anyway.

[b52src]

Same issue happens with engineer's décor windows as well
not sure if there is a simple command to clear waterlogging on all blocks in the area.

[MichaelHillcox]

Unfortunately not, it's on our radar to fix though :D

[b52src]

Curious if i take the debug stick and set all the blocks waterlog state to false manually before I copy the building is a valid workaround, not sure if anyone has tried it.

Neverminded tested toggling the waterlog state of the Engineers decor items on and off after placing in world to ensure waterlog is false and still spawns in the world waterlogged

[hvdklauw]

Yes, we copy certain states from the blocks to copy and reset others to their default values. Weirdly enough some blocks have a default state that makes them waterlogged while when the player places them they are not.

So yes, it's kinda buildinggadget doing it, but also not. The default state of a block should never be waterlogged.

[b52src]

ok got it
@stfwi
stfwi/engineers-decor/issues/162 created for this on Engineers Decor repo

[stfwi]

Hi, gonna take a look at/fix at the weekend in the ED mod. I agree the default states should be defined correctly in the mods providing the blocks, workarounds here may have other negative side effects. Cheers!