Buildinggadgets: Banners Lose Patterns

[WenXin20]

Minecraft v1.15.2
Forge v31.2.45
Building Gadgets v3.4.0

Banners placed by the copy-paste gadget lose their patterns. The same happens with player heads. If the mod Silk Chests is installed, chests containing items will also lose their contents. (I haven't tried Shulker Boxes yet)

[MichaelHillcox]

Yeah, I think this is an issue with the botched TileEntity support, I’ll have a look into it :)

[WenXin20]

Thanks! Much appreciated.

[MichaelHillcox]

I'm going to fix this on 1.16 and backport it once it's done, It'll miss 3.4.1 unfortunatly as it's a big fix

[hvdklauw]

Ok, did some debugging, the issue is with the copy part of the gadget.

On InventoryHelper.java#L279 the result of the TileSupport.createTileData(world, pos) is null.

Diving down we get to TileSupport.java#L39 which loops just once and res = null

On line TileSupport.java#L66 we check if the entity is an instance of ITileDataProvider which it isn't because it's a minecraft banner.

Somewhere in there it has to get the correct data from the entity, but I'm not sure where; also because certain other items shouldn't be restorable with all their data (chest contents, or other dupe bugs)