Browser-laptop: Fix strange color of brave menu button when alert is displayed

[luixxiul]

Test plan

https://github.com/brave/browser-laptop/pull/11415#issue-264239707

---

Describe the issue you encountered: Fix strange color of brave menu button when alert is displayed.

See: https://github.com/brave/browser-laptop/issues/9285#issue-233868886

• Platform (Win7, 8, 10? macOS? Linux distro?): 0.16.9

• Actual result:
  

• Expected result: instead of applying opacity, change the color to grey, with the counter.
  

• Extra QA steps:
  1.
  2.
  3.

• Any related issues: https://github.com/brave/browser-laptop/issues/9285#issuecomment-310832912

[alexwykoff]

@luixxiul is this still a bug? What are the actual STR?

[bsclifton]

@alexwykoff you can repro by running the following:
https://jsfiddle.net/6zj4sjxr/

I don't think it's a bug- I actually prefer how it looks (since grayed out looks like nothing is blocked). But I think it's a good one to talk about 😄

[bsclifton]

cc: @bradleyrichter @jenn-rhim

[luixxiul]

I felt it was weird as the counter block background color was not changed.

[bradleyrichter]

If this state seems correct, then we need to add a disabled style for the counter block so it doesn't look broken.

On Sep 16, 2017, at 11:52 PM, Suguru Hirahara [e-mail] wrote:

I felt it was weird as the counter block background color was not changed.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[luixxiul]

The same opacity value applied to the disabled button will be applied to the counter block as well.

[srirambv]

Verified on Windows x64 using

• 0.23.8 06c657b
• muon 6.1.5
• libchromiumcontent 66.0.3359.181

Verified on Ubuntu 17.10 x64

• 0.23.8 06c657bb7ee5530f93c37f51cc6b7bf158912d04
• Muon 6.1.5
• libchromiumcontent 66.0.3359.181

Verified with macOS 10.12.6 using

• 0.23.8 06c657b
• Muon 6.1.5
• libchromiumcontent 66.0.3359.181