Browser-laptop: "History" disappeared from menu

Created on 14 Jun 2017  路  3Comments  路  Source: brave/browser-laptop

Test plan

See https://github.com/brave/browser-laptop/pull/9477

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes. But maybe I missed the existing issue.

  • Describe the issue you encountered:
    History not shown in menu. Can not click on it.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Win 8.1

  • Brave Version (revision SHA):
    0.17.1 (6482f15)

  • Steps to reproduce:

    1. Show menu by click Alt on keyboard.
    2. Noticed that History is not there.
  • Actual result:
    There's no History. Only empty space.

  • Expected result:
    History and its sub-menu is shown.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?
    Yes.

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    brave-history-menu-missing

  • Any related issues:

OWindows Qchecked-Win32 Qchecked-Win64 Qtest-plan-specified bug featurhistory release-noteexclude

Most helpful comment

@eljuno thanks for finding this! I've repro'd on Windows 10, Brave 0.17.2 839e68b
STR:

  • Fresh Brave; activate system app menu with Alt; looks normal
  • Open webpage in new tab
  • Close the tab
  • Alt; system app app menu is missing History

@bsclifton likely related to #9191. I developed on MacOS and the windows code path is slightly different.

All 3 comments

cc: @ayumi

Could this be related to https://github.com/brave/browser-laptop/pull/9191?

@eljuno thanks for finding this! I've repro'd on Windows 10, Brave 0.17.2 839e68b
STR:

  • Fresh Brave; activate system app menu with Alt; looks normal
  • Open webpage in new tab
  • Close the tab
  • Alt; system app app menu is missing History

@bsclifton likely related to #9191. I developed on MacOS and the windows code path is slightly different.

Marking as release-notes/exclude since this was introduced (and then fixed) in the same release 馃槃

Was this page helpful?
0 / 5 - 0 ratings

Related issues

bsclifton picture bsclifton  路  3Comments

jonathansampson picture jonathansampson  路  3Comments

octohedron picture octohedron  路  3Comments

lukemulks picture lukemulks  路  3Comments

jkup picture jkup  路  3Comments