Browser-laptop: wiki: Brave Windows build guide: Updates for new Visual Studio install process

Created on 14 Apr 2017 · 8Comments · Source: brave/browser-laptop

Did you search for similar issues before submitting this one?

Yes

Describe the issue you encountered:

I am having to reinstall the Brave dev prereqs after a fresh Windows 10 re-install.

Our directions in the Brave Windows build guide have saved me countless times, but I noticed that the latest version of Visual Studio now has different installation options than it has had in the past, which no longer match our instructions from our build guide.
I would update this myself, but I'm not exactly sure which options we need to have users select from. In my case, I still have an older installer that I can temporarily use, but new users will have issues with this.

@jonathansampson & @bsclifton - is there any chance either of you could take a look at the latest way the install options are presented, and update our build guide? I'm not exactly sure, and I have a feeling if I tinker with this it's going to burn a lot of time in trial/error.

I'm going to include screenshots below that I've captured from the new UI.

Visual Studio now has an option to select Workloads or Individual Components

Workloads options
vs-install-new-workloads-0-04142017

vs-install-new-workloads-1-04142017

Individual Components options
vs-install-new-indcomponents-0-04142017

vs-install-new-indcomponents-1-04142017

vs-install-new-indcomponents-2-04142017

OWindows bugood-first-bug documentation ✍ help wanted

Source

lukemulks

👍1

All 8 comments

Isn't it possible to set up VM image where Visual Studio is installed? That would be a perfect solution :-D

luixxiul on 15 Apr 2017

@luixxiul this would be perfect... but there are licensing issues. The easier solution would be to pre-compile and package the dependencies that are being compiled from source

If you all wanted to give a +1, check out https://github.com/brave/browser-laptop/issues/5685 😄

bsclifton on 16 Apr 2017

👍1

@lukemulks This is what I selected from the installer and it worked fine for me.
@bsclifton can confirm if this is right?

srirambv on 19 Apr 2017

As far as WIn10 SDK goes, only 14393 SDK. Having win10 SDKs installed might even use the wrong one and cause problems.

From the chromium docs:

Visual Studio

As of December 8, 2016 Chromium requires Visual Studio 2015, with the 14393 Windows SDK to build.

Install Visual Studio 2015 Update 3 or later - Community Edition should work if its license is appropriate for you. Use the Custom Install option and select:

Visual C++, which will select three sub-categories including MFC
Universal Windows Apps Development Tools > Tools (1.4.1) and Windows 10 SDK (10.0.14393)
You must have the 14393 SDK installed or else you will hit compile errors such as undefined or redefined macros.

Install the Windows SDK 10, and choose Debugging Tools For Windows when you install this in order to get windbg and cdb. The latter is required for the build to succeed as some tests use it for symbolizing crash dumps.

bbondy on 21 Apr 2017

None of the above worked for me. Eventually, I got it to build via:

npm install --global --production windows-build-tools

from the https://github.com/nodejs/node-gyp build instructions.
Can someone else confirm?

bs on 27 Apr 2017

Maybe will help https://github.com/Romvik/guide-brave-browser-build-windows/tree/master

ghost on 29 Jul 2017

I fixed this in the wiki by adding the info on how to install with windows-build-tools from npm. This is the way I have been using c++ build tools and it works correctly as far as i know...

The revision changes can be found here