Browser-laptop: Menu item's hit/clickboxes are way off when maximized

[Zuzu-Typ]

Did you search for similar issues before submitting this one?
yes

Describe the issue you encountered:
When Brave is maximized, some of the buttons' don't have the right hitboxes

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 x64

• Brave Version (revision SHA):
  0.13.0 Prev5

• Steps to reproduce:

  1. Maximize Brave
  2. (try to) click on some of the items of the Brave menu. (such as the URL-bar, the new-tab-plus or the minimize / restore buttons)
  3. be shocked

• Screenshot if needed:
  Unfortunately I could only record the new-tab-plus...
  

• Any related issues:
  https://github.com/brave/browser-laptop/issues/4922 , https://github.com/brave/browser-laptop/issues/6258

[Zuzu-Typ]

For the minimize / restore buttons the hitbox is extended downwards once you've hovered over one of them.
Half of the URL-bar is cut off.
Some other icons are sometimes not clickable at all, such as the refresh, favorize and lock icons.

[Zuzu-Typ]

I now found out that you are able to click those formerly unclickable buttons, when opening the menu.
You can clearly see it here: http://www.mfi.re/file/9phwck80dm94q8i/0135.avi

[bsclifton]

@Zuzu-Typ what resolution and/or DPI are you using? When you go to display settings for example, are you at 125%?

[Zuzu-Typ]

I think I'm using 1920x1080 at 100% DPI (or whichever is the default Windows 10 setting, as I cannot access my PC for the next couple of days).
I technically have a resolution of 3840x1080 with dual monitors, but that's just a side-note.
I wish you luck!

[Zuzu-Typ]

Apparently the hitboxes are also corrected once you open the dropdown menu...

[Zuzu-Typ]

Here's a gif of the other hitboxes

[bsclifton]

Possibly fixed by https://github.com/brave/muon/commit/30fd6ff5ac772cb645b0d4be78fae49d84fbbb19

We'll want to retest with next build :smile:

[luixxiul]

Labelled QA/requiredfor the possibility that this has been fixed.

[bsclifton]

@luixxiul awesome, thanks for creating this tag (it should help a lot :smile: )

[bbondy]

@srirambv @luixxiul @alexwykoff could this one be retested with Preview 8?

[Zuzu-Typ]

The new-tab-plus-sign seems to be fixed in Prev8 one-way at least...
On entering the hitbox, the plus changes color as intended, thow it keeps this color as long as the mouse stays on the dark-gray area of the taskbar.
This also applies for the minimize and restore icons.
Here's a visual representation:

Otherwise the issue persists.

[bsclifton]

@Zuzu-Typ good finds! Just to confirm: are you on 200% DPI?

[srirambv]

@bbondy This is how it looks on Win 10 with preview 8 build. The click is off only when the hamburger menu is opened and if you try to click the refresh/home/new tab buttons but it doesn't always happen( Once the hamburger menu is closed the click is recognized only in this scenario)

The other thing that looks off to me is the new tab button on hover color remains same even if the mouse pointer it moved away from it on the tabs bar into the empty space. Is this expected??

[Zuzu-Typ]

@bbondy I guess you mean this:

As I said it is the default Windows 10 config.

[bsclifton]

@Zuzu-Typ perfect- that is exactly what I meant :smile: So you are at 100% DPI

With modern laptops having such high resolutions, many people's computers are automatically configured to be 125% or 200% stock (for example, Surface Book is 200% stock). The default option is hard to guess- thanks for clarifying :smile:

[bsclifton]

@srirambv is there any difference with Preview 9?

[srirambv]

@bsclifton Quite a lot better than preview 8. Here's the observation on preview 9

1. The new tab hit area is limited now(as expected) so is the window buttons.
2. Hamburger menu tends to be retained as long as the mouse pointer is in the tabs area. Similar to #6700
3. Bookmark hit area seems to be only on the star, slight off click on the bookmark area is not recognized

Other than that looks good to me. Will log an issue for item 3

Here's the recording for this on preview 9 http://sendvid.com/pyjysocm

Edit: Bookmark hit area is same on 0.12.15 as well

[srirambv]

Here's how the bookmark area looks like. Its very small area around the star that is recognized and adds a bookmark.

@bradleyrichter Shouldn't the entire area the star is in be considered as hit area to add a new bookmark?

[bradleyrichter]

@srirambv yes, ideally the entire rectangle would be clickable. This is especially important in hi-def desktop views.

[bsclifton]

Closing issue as it looks like this has been resolved

@srirambv please create a new issue if there are still problems. Thanks :smile:

Test plan from the original post

1. Be on Windows at 100% DPI
2. Maximize Brave
3. (try to) click on some of the items of the Brave menu. (such as the URL-bar, the new-tab-plus or the minimize / restore buttons)
4. Before, you may have been shocked because it doesn't work; however, it should work beautifully now.

[srirambv]

Preview 10 looks same as on preview 9. 👍

[Zuzu-Typ]

It seems that the issue is back.

Unfortunately I couldn't go back to version 0.13.0 preview 10 to check if the issue reoccured or wasn't fixed in it's entirety, because the browser would throw an uncaught exception and crash.

However in every version from 0.13.2 to the current git repository (03/03/17) some hitboxes are off.

This applies for most hitboxes, including the favorize button, the reload button, the new-tab button, the search icon and (especially) the url bar itself. All of their hitboxes are a little offset to the left and up.
So much so, that you can only click the upper half of the url bar.

[Zuzu-Typ]

Here's a visual representation of where the hitboxes are, when the window is maximized.