Browser-laptop: about:newtabs - have relevant results shown (implement frecency)

[bsclifton]

cc: @bbondy @bradleyrichter

With some favorite sites up in the "Top Sites" area, the items are not easy to identify.

We need to find a better way to represent bookmarks which have the same favicon:

• having a bunch of medium.com posts pinned or in favs, which will all have the same icon
• bookmarking multiple parts of brianbondy.com :smile:
• tweets

[luixxiul]

Eventually you will have this one..

Is this a card game? :-D

[bsclifton]

@srirambv brought up a great concern here (similar to @luixxiul's concern) https://github.com/brave/browser-laptop/issues/5347

Multiple sites on the same origin will each take up a tile. Is this behavior that we want?

[bradleyrichter]

We need to dedupe. The example above would simply make GitHub the top site and you would have a link to github.com on a single tile.

On Nov 2, 2016, at 11:11 AM, Brian Clifton [email protected] wrote:

@srirambv brought up a great concern here (similar to @luixxiul's concern) #5347

Multiple sites on the same origin will each take up a tile. Is this behavior that we want?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[bsclifton]

Requirements (please edit this post as needed):

• [ ] Only show one link per domain
  
  
  
  • Use a frecency algorithm; for more info, click here
  
  
  • Another frecency example here (bug for that tracked here)
  
  
• [x] Tile can remain as the favicon with the theme color (although, folks can turn off theme color in Preferences > Tabs. In this case, is theme color still recorded?)
• [x] Mousing over needs to show the title (which it does currently)

Brad's additions:

• [ ] let's make sure we are using the same text color code as the tabs which should prevent low or zero contrast results
• [x] set opacity of mouse-hover popup tools to 80% so they are always visible
• [x] make sure default view is 1 row, and cycles as 1-2-3-1-2-3

[bsclifton]

Also- if we wanted nicer high-res non-favicons, we could consider spriting up like a top 20 sheet

[bsclifton]

Moving to 0.12.10. For 0.12.9, the ideal behavior would be to limit folks to only 1 row of icons (until we're able to resolve this issue and the other issues)

cc: @cezaraugusto

[cndouglas]

Related issue: #5482 (only one row of topSites)

[bbondy]

Moving to 0.12.10 but would consider moving back if a PR is in place.

[bbondy]

Please update to use the same algorithm with frecency as is done for urlbar suggestions.

[bsclifton]

Note per our convo: we can use the frecency algorithm from suggestions.js, but we'd need to move the code to the renderer process

[bradleyrichter]

@bsclifton Do we need a separate issue for deduping as a first pass or combine it with frecency?

[bsclifton]

@bradleyrichter deduping should be done now (the first pass that is). If you choose to pin a site, then it won't count as a dupe (ex: you'll be shown 1 other result from that domain).

You will notice that the duping is based on hostname (which does not remove the subdomain name), which means https://blog.brave.com/ and https://brave.com/ count as two sites.. We could change this logic and instead strip off subdomain?

[bradleyrichter]

google has so many sites/tools with subs so let's go with that. (each sub counts as a sep site)

[bsclifton]

With deadline for milestone being tonite, moving to 0.12.11

[bbondy]

This would be great to get to use Aubrey's frecency, but since we only show 6 tiles currently and they are pretty accurate most of the time as is we can move to backlog for now.

The fix here is to use this sorting:
https://github.com/brave/browser-laptop/blob/master/app/renderer/lib/suggestion.js

But I think suggestion.js has to move to common.

[bsclifton]

This should be completely fixed with brave-core