Brave-ios: Remove/Replace "?" from rewards onboarding string

[kjozwiak]

Description:

Looks like there's a ? at the end of the reward onboarding string which doesn't make sense.

Steps to Reproduce

1. install 1.22 (20.11.25.21) via TF
2. run through onboarding till you get to rewards

Actual result:

Expected result:

I'm not 100% sure what it should be, but maybe using ! or a period makes more sense. CCing @jamesmudgett @anthonypkeane to decide how the string should look like.

Reproduces how often: [Easily reproduced, Intermittent Issue]

100% reproducible using the above STR.

Brave Version:

• 1.22 (20.11.25.21)

Device details:

• iPhone 11 running iOS 14.2 - Reproduced

Website problems only: N/A

• did you check with Brave Shields down? N/A
• did you check in Safari/Firefox (WkWebView-based browsers)? N/A

Additional Information

CCing @bsclifton @srirambv

[kylehickinson]

Just verified that this was indeed what was in the Figma file 😅:

[srirambv]

cc: @karenkliu

[iccub]

this requires new translations, would be better to address it in next release,
we can hotfix it quickly for English lang though

[karenkliu]

I think it the ? was just supposed to be a period . lol @iccub
A Figma typo! 🙈

[kjozwiak]

• Verification PASSED on iPhone 11 running iOS 14.2 using 1.22 (20.12.2.0)
• Verification PASSED on iPad Air (3rd Gen) running iOS 14.0.1 using 1.22 (20.12.2.0)
• Verification PASSED on iPhone 6s+ running iOS 12.4.1 using 1.22 (20.12.2.0)

Ensured ? was removed from onboarding as per https://github.com/brave/brave-ios/issues/3081#issue-751219638. Examples:

iPhone 11 | iPad Air (3rd Gen) | iPhone 6s+ |
-----------------|---------------------------|------------------|
| |

[kjozwiak]

this requires new translations, would be better to address it in next release,
we can hotfix it quickly for English lang though

Created https://github.com/brave/brave-ios/issues/3100 so the above doesn't fall through the cracks. Still needs to be fixed for all locales other than English.