Brave-browser: New Sync v2 UI wiring
TODO
- Initial "Start using Sync"
- [ ] should change to "manage your sync'd devices" after setup
- Sync Setup dialog
- [ ] images
- [ ] 'mobile' QR code
- [ ] should navigate to "Sync Manager" screen after starting
- Sync Manager
- [ ] "Leave Sync Chain" should confirm first
- [ ] Device List
- [ ] Sync Settings list
Description
Because of the way that sync functionality is currently loaded as a component with react UI we cannot directly reuse the configuration interface for sync. Because of that and in order to more seamlessly integration sync v2 configuration, we need to rework and rewire the current sync settings UI.
Primary changes are as follows:
1) The link to sync from settings can now link directly to it's settings page ("Start Using Sync" before configured, "Manage your sync'd devices" once setup)
2) The join process should have the same flow as v1
3) There is a new list of sync devices, but they should now be wired into the Chromium sync records corresponding to those devices. You should still be able to "Leave Sync Chain" for your device, which should first remove the current device's sync record, before disabling sync. However, you can no longer remove other devices from the sync chain ("Remove" column goes away, and please ignore the "X"s currently in the mockup).
jsecretan
All 35 comments
@jsecretan
The link to sync from settings
which link?..
on the first picture, what happens if I choose "Computer"?
iefremov
on 16 Apr 2020
@iefremov it should show the screen above but with the actual sync words
rebron
on 16 Apr 2020
For link should be brave://sync to redirect to brave://settings/braveSync.
The two urls for sync will be:
brave://settings/braveSync
brave://settings/braveSync/setup
cc: @darkdh @bradleyrichter
rebron
on 16 Apr 2020
Bookmarks were the only ones that were being synced but that doesn't work anymore since a month+
Any ETA on when sync will be enabled again?
madhums
on 16 Apr 2020
Yes, asking for the same. any ETAs when we can expect the enabled sync?
akash07k
on 27 Apr 2020
I used Brave in its early stages and I liked it already very much. Although I switched back to Chrome for some bug at that time. I went back to Brave a couple of weeks ago and I LOVE it, the only issue for me is that sync is not available as I recently found out and lost all my bookmarks after a reinstall. So therefore I'm also curious if there is an ETA on the Sync feature.
frankgraave
on 29 Apr 2020
Sync and isolation features (like firefox multi-account containers) are the two sticking points preventing me from making Brave my default browser. Without _both_ of these, Brave will remain a third-choice tool after FF and links (yes. a text-mode browser currently beats out Brave in preference hierarchy).
So. I don't actually see any recent commit history of significance regarding sync, even if I scan across branches (a branch pruning is long past-due.) Is it actively being worked on, per the Reddit post, last month, claiming it to be "top priority?"
ParaplegicRacehorse
on 1 May 2020
@ParaplegicRacehorse check the roadmap https://github.com/brave/brave-browser/wiki/Roadmap#q2-2020-april---june It's at the top of the list for this quarter.
HeyITGuyFixIt
on 2 May 2020
Oh, means end of june. :( that too is not sure. :(
On 5/2/20, Christian Sirolli notifications@github.com wrote:
@ParaplegicRacehorse check the roadmap
https://github.com/brave/brave-browser/wiki/Roadmap#q2-2020-april---june
It's at the top of the list for this quarter.--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/brave/brave-browser/issues/9241#issuecomment-622941154
akash07k
on 2 May 2020
@ParaplegicRacehorse check the roadmap https://github.com/brave/brave-browser/wiki/Roadmap#q2-2020-april---june It's at the top of the list for this quarter.
on the Roadmap, and receiving attention-currency from devs are not the same. As I previously mentioned, the announcement to Reddit is almost a month old (how long has this item been in this place on the Roadmap?) and has received zero commits. The quarter is 30% over...
Look, I'm okay keeping Brave around as my 3rd-choice browser. I really like the ideals and it would be nice to shift it to 2nd or 1st preference position.
Anyway, what are the particular difficulties being experienced with sync? Is it wallet integration? Because, frankly, that's the easy one to sort out.
ParaplegicRacehorse
on 2 May 2020
@ParaplegicRacehorse you can track sync core work here https://github.com/brave/brave-core/pull/5294
NejcZdovc
on 2 May 2020
Has this part of the code pushed to the beta builds?
shivashranz
on 19 May 2020
I think no
On 5/19/20, shivashranz notifications@github.com wrote:
Has this part of the code pushed to the beta builds?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/brave/brave-browser/issues/9241#issuecomment-630784589
akash07k
on 19 May 2020
No, not just yet, hoping to merge down into nightly in the next couple of weeks.
jsecretan
on 22 May 2020
Please let us know when it gets merged
On 5/22/20, jsecretan notifications@github.com wrote:
No, not just yet, hoping to merge down into nightly in the next couple of
weeks.--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/brave/brave-browser/issues/9241#issuecomment-632651840
akash07k
on 22 May 2020
Hello, I recently started using Brave and I've been very pleased! However, I _regularly_ on 3 different devices and 4 different OS. Not having Sync is...not good. But you know this! Keep up the great work - this is a really fantastic browser and I'm looking forward to evangelizing it when it's ready.
galenballew
on 27 May 2020
I'm dying to start using brave again the moment password syncing works. Subscribed!
joel-g
on 2 Jun 2020
Any recommend a cross plat and cross browser bookmark only syncing service for the meantime?
frankfuu
on 2 Jun 2020
@frankfuu you could try pocket
shaneparsons
on 2 Jun 2020
hi guys i have brave on my macOS 10.13.6 but i cant found sync , i search with your indication but nothing, what i can do?
JKWork3
on 3 Jun 2020
@JKWork3 you can manually re-enable right now via flags: https://support.brave.com/hc/en-us/articles/360042159452-How-do-I-re-enable-Brave-Sync- but the current version of sync will soon be discontinued for the new version.
jsecretan
on 3 Jun 2020
will be nice if we can sync more than just the bookmarks. Like plugins, configuration, etc
KhimairaCrypto
on 4 Jun 2020
will be nice if we can sync more than just the bookmarks. Like plugins, configuration, etc
Would be nice, but bookmarks _only_ would be a good MVP to get done first and solve the real pain point.
Manually installing a few plugins is pretty easy, as is using a third party plugin manager.
frankyw
on 4 Jun 2020
I agree with @frankyw . Bookmarks is the only crucial one in my opinion.
frankfuu
on 5 Jun 2020
Any recommend a cross plat and cross browser bookmark only syncing service for the meantime?
try https://www.xbrowsersync.org/ working for me pretty well (and integrates with other desktop browsers, mobile ymmv)
paulsjenkins
on 5 Jun 2020
Finally I switched to Firefox.
far better. very nice sync implementation as well as better than chrome.
On 6/5/20, Paul Jenkins notifications@github.com wrote:
Any recommend a cross plat and cross browser bookmark only syncing service
for the meantime?try https://www.xbrowsersync.org/- working for me pretty well (and
integrates with other desktop browsers, mobile ymmv)--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/brave/brave-browser/issues/9241#issuecomment-639331076
akash07k
on 5 Jun 2020
Finally I switched to Firefox. far better. very nice sync implementation as well as better than chrome.
…
On 6/5/20, Paul Jenkins @.*> wrote: > Any recommend a cross plat and cross browser bookmark only syncing service > for the meantime? try https://www.xbrowsersync.org/- working for me pretty well (and integrates with other desktop browsers, mobile ymmv) -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #9241 (comment)
Agree! The sync side, just works and it sync more than just the bookmarks. Are you guys are going to extend the sync functionality as part of an additional ticket?
KhimairaCrypto
on 6 Jun 2020
It would also be nice to have import/export from/to file for the Android Browser (https://github.com/brave/brave-browser/issues/6378). In Sync v1 about 130-170 bookmarks are synced every 80 seconds, which is quite slow (especially if you have a large number of bookmarks). I presume Sync v2 will be roughly the same speed.
artella-coding
on 6 Jun 2020
Thanks @artella-coding, hoping that this will be faster but the import/export is probably a good idea in any case. We'll have a better sense of speed for everybody over the next couple of weeks.
jsecretan
on 8 Jun 2020
And @KhimairaCrypto we trying to get this deployed with most of the sync types available on desktop/Android, and they'll slowly work their way to iOS. So if all goes well, you'll have more than just bookmarks.
jsecretan
on 8 Jun 2020
🎉
szaimen
on 12 Jun 2020
👏🙏
oraculum
on 12 Jun 2020
🥳
o4dev
on 14 Jun 2020
Verification passed on
Brave | 1.12.107 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Ubuntu 18.04 LTS
Verification done in https://github.com/brave/brave-browser/issues/9989#issuecomment-669639155
Also verified UI for German and Polish locale.
Verification passed on
Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
--- | ---
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 2004 (Build 19041.423)
- Verification is done in https://github.com/brave/brave-browser/issues/9989#issuecomment-669639155
Verification PASSED on macOS 10.15.6 x64 using the following build:
Brave | 1.12.112 Chromium: 84.0.4147.125 (Official Build) (64-bit)
-- | --
Revision | d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS | macOS Version 10.15.6 (Build 19G73)
- Verification was completed via https://github.com/brave/brave-browser/issues/9989#issuecomment-669639155
btlechowski
on 6 Aug 2020
Is it shipped in nightly or stable?
On 8/6/20, btlechowski notifications@github.com wrote:
Verification passed on
>
Brave | 1.12.107 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision |
a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Ubuntu 18.04 LTS
>
Verification done in https://github.com/brave/brave-browser/issues/9989
Also verified UI for German and Polish locale.
>
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/brave/brave-browser/issues/9241#issuecomment-669639566
akash07k
on 6 Aug 2020
Related issues
LaurenWags
·
47Comments
Brave-Matt
·
58Comments
bsclifton
·
54Comments
bsclifton
·
87Comments
kenthunt
·
70Comments
Most helpful comment
Hello, I recently started using Brave and I've been very pleased! However, I _regularly_ on 3 different devices and 4 different OS. Not having Sync is...not good. But you know this! Keep up the great work - this is a really fantastic browser and I'm looking forward to evangelizing it when it's ready.