Brave-browser: Brave Ads campaign startAt and endAt should be based on UTC and not local time

[tmancey]

Description

Brave Ads campaign startAt and endAt should be based on UTC and not local time

Steps to Reproduce

1. View an ad notification (which has expired in UTC, but not expired in your local time zone)

Actual result:

Ad notification is shown

Expected result:

Ad notification should not be shown

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

See catalog and search for startAt and endAt in a campaign

[GeetaSarvadnya]

@tmancey As per the subject of the issue Brave Ads campaign startAt and endAt should be based on UTC and not local time - we have set the expired UTC time for the Campaign end date and tested the issue, we are not getting ads in 1.9.x as UTC time is already expired. (working as expected, assuming ads should trigger based on UTC not based on local time)

As per the description of the issue 1. View an ad notification (which has expired in UTC, but not expired in your local time zone) - are we supposed to get ads based on the local time when UTC time expired? - Please clarify this. Thanks!

[tmancey]

No you should not get ads based on locale time. Start and end dates are in UTC

[btlechowski]

Verification passed on

Brave | 1.9.66 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Ubuntu 18.04 LTS

[PASS] Verified startAt available local time and UTC - ad was shown
[PASS] Verified startAt available local time but not UTC - ad was not shown
[PASS] Verified startAt available UTC but not local time - ad was shown
[PASS] Verified endAt available local time and UTC - ad was shown
[PASS] Verified endAt available local time but not UTC - ad was not shown (UTC-2)
[PASS] Verified endAt available UTC but not local time - ad was shown (UTC+2)

Verification passed on

Brave | 1.9.66 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the description from the issue and ensured that ads are shown based on UTC time not based on the local time

Scenario 1: [Expired UTC time set for Campaign end date]- PASSED

Pre-requisites: Created a catalog file with 1 CampaignID and 1CreativeSetID and multiple ads in it and set the Campaign end date to expired UTC time (UTC-1). Catalog file which is overwritten in Charles proxy is
UTC time check.txt

• Verified scenario 1 on version 1.9.x and ensured that ads were not shown as the UTC time is expired for the Campaign end date.
• Verified scenario 1 on version 1.8.x and ensured that ads were shown as ads were triggered based on the local time

Scenario 2: [UTC time for Campaign end date is valid (not expired) but local time is set behind the UTC time] - PASSED
Pre-requisites: Created a catalog file with 1 CampaignID and 1CreativeSetID and multiple ads in it and set the Campaign end date to valid UTC time. Used same catalog file which is attached above just changed the campaign end date

• Verified scenario 2 on version 1.9.x and ensured that ads were triggered based on the UTC time even though the local time is not valid

---

Verified passed with

Brave | 1.9.68 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

[PASS] Verified startAt available local time and UTC - ad was shown
[PASS] Verified startAt available local time but not UTC - ad was not shown
[PASS] Verified startAt available UTC but not local time - ad was shown
[PASS] Verified endAt available local time and UTC - ad was shown
[PASS] Verified endAt available local time but not UTC - ad was not shown (UTC-4)
[PASS] Verified endAt available UTC but not local time - ad was shown (UTC+2)