Brave-browser: Update Safe Browsing API key

Created on 13 Jul 2018 · 5Comments · Source: brave/brave-browser

Test Plan

Ensure location is shown on maps.google.com when Your location is clicked
Navigate to https://testsafebrowsing.appspot.com/ and verify that you see appropriate warnings for different demo pages

--
The dev safe browsing key is limited to 2000 requests per day. Reach out to google to get an updated key with increased request quota per day. cc: @flamsmark

QA Pass-Linux QA Pass-Win64 QA Pass-macOS QYes audit-non-blocking

Source

jumde

Most helpful comment

The new key has been generated, we have upgraded the quota for the key as well. @mbacchi and @RyanJarv are working on setting up key in the proxy. Issue tracked here: https://github.com/brave/devops/issues/208

cc: @tomlowenthal

jumde on 9 Sep 2018

👍3

All 5 comments

Generated the key.
Will be double checking the proxy is working on Monday.
will work with team to make sure the key is used in future CI builds for all channels.

w0ts0n on 17 Aug 2018

👍1

Note: If using environment variables look for the npm_config_brave_google_api_key and npm_config_brave_google_api_endpoint environment variables as examples of how this works in the Jenkins build jobs currently.

mbacchi on 21 Aug 2018

What's the current status on this one @w0ts0n ? Thanks!

bbondy on 9 Sep 2018

cc: @tomlowenthal

jumde on 9 Sep 2018

👍3

Verification Passed on

Brave | 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
-- | --
Revision | 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS | Linux

Verification PASSED on

Brave | 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
-- | --
Revision | 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS | Windows

Verified passed with

Brave | 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
-- | --
Revision | 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS | Mac OS X